After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 458567 - Ship with windows gtkrc
Ship with windows gtkrc
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Windows
2.2.x
Other Windows
: Normal trivial
: ---
Assigned To: Andreas Köhler
Christian Stimming
Depends on:
Blocks:
 
 
Reported: 2007-07-20 08:33 UTC by Robert T.
Modified: 2018-06-29 21:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
before applying windows gtkrc (71.59 KB, image/png)
2007-07-20 10:37 UTC, Robert T.
Details
after applying windows gtkrc (98.64 KB, image/png)
2007-07-20 10:37 UTC, Robert T.
Details

Description Robert T. 2007-07-20 08:33:26 UTC
Please, ship the windows build with the windows version of gtkrc enabled - copied to etc\gtk-2.0 from share\themes\MS-Windows\gtk-2.0
Comment 1 Christian Stimming 2007-07-20 08:42:24 UTC
Thanks for this suggestion. Could you please elaborate/explain what this means, what the desired effects are, and how this would affect users with an already existing gtk setup? Thanks.
Comment 2 Robert T. 2007-07-20 10:36:29 UTC
No problem.

I mean that the default look and feel of the Windows version of gnucash looks all dull, grey and squarish. After I have copied file 
C:\Program Files\gnucash\share\themes\MS-Windows\gtk-2.0\gtkrc 
to 
C:\Program Files\gnucash\etc\gtk-2.0\gtkrc
gnucash looks more in place and integrated with other Windows applications.

Since gnucash uses its own gtk, doing the above will not affect users with already existing gtk setup (if such people exist on Windows).

Screenshots before and after attached.

Keep up the great work,
Robert
Comment 3 Robert T. 2007-07-20 10:37:17 UTC
Created attachment 92030 [details]
before applying windows gtkrc
Comment 4 Robert T. 2007-07-20 10:37:44 UTC
Created attachment 92031 [details]
after applying windows gtkrc
Comment 5 Christian Stimming 2007-07-20 11:08:20 UTC
Whoa. Thanks for the screenshot, this is convincing enough.

I'd propose to add the following to dist.sh:

Index: packaging/win32/dist.sh
===================================================================
--- packaging/win32/dist.sh     (Revision 16320)
+++ packaging/win32/dist.sh     (Arbeitskopie)
@@ -93,6 +93,7 @@
     wget_unpacked $PANGO_URL $DOWNLOAD_DIR $DIST_DIR
     wget_unpacked $LIBART_LGPL_URL $DOWNLOAD_DIR $DIST_DIR
     wget_unpacked $GTK_URL $DOWNLOAD_DIR $DIST_DIR
+    cp $DIST_DIR/share/themes/MS-Windows/gtk-2.0/gtkrc $DIST_DIR/etc/gtk-2.0
     wget_unpacked $ORBIT2_URL $DOWNLOAD_DIR $DIST_DIR
     wget_unpacked $GAIL_URL $DOWNLOAD_DIR $DIST_DIR
     wget_unpacked $POPT_URL $DOWNLOAD_DIR $DIST_DIR
Comment 6 Christian Stimming 2007-07-20 22:12:45 UTC
Applied in r16340. Thanks a lot.
Comment 7 Zach Sadecki 2007-07-21 16:18:44 UTC
just an FYI, the windows theme suffers from bug 432021
Comment 8 John Ralls 2018-06-29 21:43:40 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=458567. Please update any external references or bookmarks.