GNOME Bugzilla – Bug 458567
Ship with windows gtkrc
Last modified: 2018-06-29 21:43:40 UTC
Please, ship the windows build with the windows version of gtkrc enabled - copied to etc\gtk-2.0 from share\themes\MS-Windows\gtk-2.0
Thanks for this suggestion. Could you please elaborate/explain what this means, what the desired effects are, and how this would affect users with an already existing gtk setup? Thanks.
No problem. I mean that the default look and feel of the Windows version of gnucash looks all dull, grey and squarish. After I have copied file C:\Program Files\gnucash\share\themes\MS-Windows\gtk-2.0\gtkrc to C:\Program Files\gnucash\etc\gtk-2.0\gtkrc gnucash looks more in place and integrated with other Windows applications. Since gnucash uses its own gtk, doing the above will not affect users with already existing gtk setup (if such people exist on Windows). Screenshots before and after attached. Keep up the great work, Robert
Created attachment 92030 [details] before applying windows gtkrc
Created attachment 92031 [details] after applying windows gtkrc
Whoa. Thanks for the screenshot, this is convincing enough. I'd propose to add the following to dist.sh: Index: packaging/win32/dist.sh =================================================================== --- packaging/win32/dist.sh (Revision 16320) +++ packaging/win32/dist.sh (Arbeitskopie) @@ -93,6 +93,7 @@ wget_unpacked $PANGO_URL $DOWNLOAD_DIR $DIST_DIR wget_unpacked $LIBART_LGPL_URL $DOWNLOAD_DIR $DIST_DIR wget_unpacked $GTK_URL $DOWNLOAD_DIR $DIST_DIR + cp $DIST_DIR/share/themes/MS-Windows/gtk-2.0/gtkrc $DIST_DIR/etc/gtk-2.0 wget_unpacked $ORBIT2_URL $DOWNLOAD_DIR $DIST_DIR wget_unpacked $GAIL_URL $DOWNLOAD_DIR $DIST_DIR wget_unpacked $POPT_URL $DOWNLOAD_DIR $DIST_DIR
Applied in r16340. Thanks a lot.
just an FYI, the windows theme suffers from bug 432021
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=458567. Please update any external references or bookmarks.