After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 457451 - HIG improvements for the "Visible Columns" dialog
HIG improvements for the "Visible Columns" dialog
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Visual Design
2.21.x
Other Linux
: Normal minor
: 2.24.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-07-16 18:46 UTC by Vincent Geddes
Modified: 2008-08-05 15:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
HIG fixes for "Visible Columns" dialog (2.08 KB, patch)
2007-07-16 18:47 UTC, Vincent Geddes 		none Details | Review
HIG fixes for "Visible Columns" dialog (2.11 KB, patch)
2007-07-16 18:51 UTC, Vincent Geddes 		none Details | Review

Description Vincent Geddes 2007-07-16 18:46:19 UTC 
Removed the dialog separator and modified the border widths and spacings appropriately.

Also changed the "." in information label to ":". So the label is now "Choose the order of information to appear in this folder:".

Also changed the response code of the "Close" button from GTK_RESPONSE_CANCEL to GTK_RESPONSE_CLOSE since it's more semantically correct, although it does not really matter in this case.
Comment 1 Vincent Geddes 2007-07-16 18:47:25 UTC 
Created attachment 91866 [details] [review]
HIG fixes for "Visible Columns" dialog
Comment 2 Vincent Geddes 2007-07-16 18:51:38 UTC 
Created attachment 91867 [details] [review]
HIG fixes for "Visible Columns" dialog
Comment 3 André Klapper 2007-07-26 13:08:53 UTC 
to get this in, you should probably poke alex on the nautilus list or on irc. ui freeze on monday.
Comment 4 Cosimo Cecchi 2008-02-29 14:13:12 UTC 
The patch still applies...setting 2.24 target so that we can get this in after 2.22 branching.
Comment 5 André Klapper 2008-08-04 23:11:05 UTC 
Cosimoc: *ping*
(Probably a UI change)
Comment 6 Cosimo Cecchi 2008-08-05 15:35:03 UTC 
I committed a better patch for this to trunk.
Closing as FIXED.

2008-08-05  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/file-manager/fm-list-view.c: (create_column_editor):
	HIG improvements for the "Visible Columns" dialog.	
	Initial patch by Vincent Geddes (#457451).