GNOME Bugzilla – Bug 456912
PATCH: make wildmidi plugin check for /etc/timidity.cfg
Last modified: 2007-08-15 13:33:39 UTC
currently the new wildmidi plugin in plugins-bad checks for wildmidi.cfg in various places, but doesn't check for timidity.cfg as it should. This is both weird and incorrect, as wildmidi upstream doesn't talk about a wildmidi.cfg, and the wildmidi lib player example defaults to /etc/timidity.cfg This patch makes the bad plugin atleast also check for /etc/timidity.cfg I know that timidity has some issues parsing certain versions of timidity.cfg files, but thats not a good reason to thus use a whole new file, esp. where upstream doesn't do this. Instead wildmidi should be fixed, I have a patch for fixing wildmidi here: http://people.atrpms.net/~hdegoede/wildmidi-0.2.2-cfg-abs-path.patch
Created attachment 91780 [details] [review] PATCH: make wildmidi plugin check for /etc/timidity.cfg
Hans, I modified to patch, as e.g. under ubuntu timidity.cfg is not in /etc/timidity.cfg but in /etc/timidity/timidity.cfg. 2007-08-15 Stefan Kost <ensonic@users.sf.net> * ext/timidity/gstwildmidi.c: * ext/timidity/gstwildmidi.h: Look harder for a config. Based on patch by Hans de Goede. Fixes #456912
(In reply to comment #2) > Hans, I modified to patch, as e.g. under ubuntu timidity.cfg is not in > /etc/timidity.cfg but in /etc/timidity/timidity.cfg. > > > 2007-08-15 Stefan Kost <ensonic@users.sf.net> > > * ext/timidity/gstwildmidi.c: > * ext/timidity/gstwildmidi.h: > Look harder for a config. Based on patch by Hans de Goede. > Fixes #456912 > Sounds good to me, I guess this bug can be closed now.