After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 456912 - PATCH: make wildmidi plugin check for /etc/timidity.cfg
PATCH: make wildmidi plugin check for /etc/timidity.cfg
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.5
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-07-14 17:27 UTC by Hans de Goede
Modified: 2007-08-15 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PATCH: make wildmidi plugin check for /etc/timidity.cfg (765 bytes, patch)
2007-07-14 17:27 UTC, Hans de Goede
none Details | Review

Description Hans de Goede 2007-07-14 17:27:23 UTC
currently the new wildmidi plugin in plugins-bad checks for wildmidi.cfg in various places, but doesn't check for timidity.cfg as it should.

This is both weird and incorrect, as wildmidi upstream doesn't talk about a wildmidi.cfg, and the wildmidi lib player example defaults to /etc/timidity.cfg

This patch makes the bad plugin atleast also check for /etc/timidity.cfg

I know that timidity has some issues parsing certain versions of timidity.cfg files, but thats not a good reason to thus use a whole new file, esp. where upstream doesn't do this.

Instead wildmidi should be fixed, I have a patch for fixing wildmidi here:
http://people.atrpms.net/~hdegoede/wildmidi-0.2.2-cfg-abs-path.patch
Comment 1 Hans de Goede 2007-07-14 17:27:51 UTC
Created attachment 91780 [details] [review]
PATCH: make wildmidi plugin check for /etc/timidity.cfg
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2007-08-15 13:27:41 UTC
Hans, I modified to patch, as e.g. under ubuntu timidity.cfg is not in /etc/timidity.cfg but in /etc/timidity/timidity.cfg.


2007-08-15  Stefan Kost  <ensonic@users.sf.net>

	* ext/timidity/gstwildmidi.c:
	* ext/timidity/gstwildmidi.h:
	  Look harder for a config. Based on patch by Hans de Goede.
	  Fixes #456912
Comment 3 Hans de Goede 2007-08-15 13:32:50 UTC
(In reply to comment #2)
> Hans, I modified to patch, as e.g. under ubuntu timidity.cfg is not in
> /etc/timidity.cfg but in /etc/timidity/timidity.cfg.
> 
> 
> 2007-08-15  Stefan Kost  <ensonic@users.sf.net>
> 
>         * ext/timidity/gstwildmidi.c:
>         * ext/timidity/gstwildmidi.h:
>           Look harder for a config. Based on patch by Hans de Goede.
>           Fixes #456912
> 

Sounds good to me, I guess this bug can be closed now.