Created attachment 91557 [details] [review]
patch

Comment on attachment 91557 [details] [review]
patch

I don't get tooltips for the arrow buttons even with the patch. In fact none of the toolbar tooltips work for me.

This is just the tooltip on the drop-down arrow of the arrow button, not the whole arrow button.

With the patch that tooltip shows up; you're correct that no other tooltips show up.

Actually there are tooltips for most of the items. No tooltips on Back/Forward, and Stop, Reload. For Stop/Reload that's because they have no tooltip defined in src/nautilus-window-menus.c; I'll file an extra bug for that. The missing tooltip on back/forward seems to be a general problem with GtkMenuToolButton, since I also see the same thing in epiphany.

Committed the patch.


        * configure.in:
        * src/nautilus-navigation-action.c: (connect_proxy),
        (disconnect_proxy):
        * src/nautilus-navigation-window-menus.c: (connect_proxy_cb),
        (refresh_go_menu):
        * src/nautilus-navigation-window.c: (location_button_create),
        (nautilus_navigation_window_init),
        (nautilus_navigation_window_destroy),
        (nautilus_navigation_window_finalize),
        (nautilus_navigation_window_class_init):
        * src/nautilus-query-editor.c: (nautilus_query_editor_dispose),
        (nautilus_query_editor_add_row), (nautilus_query_editor_init),
        (finish_first_line):
        * src/nautilus-side-pane.c: (side_panel_free),
        (nautilus_side_pane_class_init), (nautilus_side_pane_init),
        (nautilus_side_pane_dispose), (nautilus_side_pane_finalize),
        (nautilus_side_pane_add_panel), (create_shortcut):
        * src/nautilus-trash-bar.c: (nautilus_trash_bar_class_init),
        (nautilus_trash_bar_init):
        * src/nautilus-window-private.h: Port to new gtk+ 2.11 tooltips API.
        Bug #458284 and bug #455616.

The broken tooltip on the main button is due to gtk bug 458283.