After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 454642 - move to gtkbuilder dropped a11y
move to gtkbuilder dropped a11y
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 454653
Blocks:
 
 
Reported: 2007-07-07 19:42 UTC by Christian Persch
Modified: 2008-03-02 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Re-add ATK properties (1.23 KB, patch)
2008-02-27 07:21 UTC, Philip Withnall
committed Details | Review

Description Christian Persch 2007-07-07 19:42:17 UTC
In the move from glade to gtkbuilder, the atk relations and labels were dropped.
Comment 1 Bastien Nocera 2007-07-08 12:27:08 UTC
Newer version of gtk-builder-convert converts those properly, will need to go over the *.ui files.
Comment 2 Bastien Nocera 2007-07-09 11:55:08 UTC
It doesn't actually convert them properly. Filed as bug 455127
Comment 3 Bastien Nocera 2007-07-09 12:01:07 UTC
Needs a newer GTK+, that's all (even though it won't do anything just yet).
Comment 4 Philip Withnall 2008-01-25 16:53:17 UTC
Resolving now that bug #454653 is fixed.
Comment 5 Bastien Nocera 2008-02-07 15:15:13 UTC
It's not fixed, all the atk properties are missing.
Comment 6 Philip Withnall 2008-02-27 07:21:41 UTC
Created attachment 106050 [details] [review]
Re-add ATK properties

Add converted ATK properties to the UI file. They don't look like much; we might want to review our accessibility for 2.24, but I don't think there's time before 2.22.
Comment 7 Bastien Nocera 2008-02-27 22:41:15 UTC
Missing properties.ui though
Comment 8 Philip Withnall 2008-02-27 22:49:55 UTC
2008-02-27  Philip Withnall  <pwithnall@svn.gnome.org>

	* data/properties.ui:
	* data/totem.ui: Re-add ATK properties to the UI files, converted
	from the glade files. (Closes: #454642)
Comment 9 Philip Withnall 2008-02-28 16:37:25 UTC
Whoops. The change to totem.ui to include the following code accidentally broke string freeze, and so I've backed it out for now. This needs re-adding to tmw_seek_hscale once we're unfrozen again:

			  <child internal-child="accessible">
                            <object class="AtkObject" id="a11y-tmw_seek_hscale">
                              <property name="AtkObject::accessible-name" translatable="yes">Time seek bar</property>
                            </object>
                          </child>
Comment 10 Bastien Nocera 2008-02-28 16:40:11 UTC
Could you ask for a string freeze break?
Comment 11 Bastien Nocera 2008-03-02 13:55:06 UTC
2008-03-02  Bastien Nocera  <hadess@hadess.net>

        * data/totem.ui: Re-add ATK properties (Closes: #454642)

2008-03-02  Bastien Nocera  <hadess@hadess.net>

        * ar.po:
        * ca.po:
        * da.po:
        * de.po:
        * he.po:
        * nl.po:
        * pl.po:
        * pt.po:
        * pt_BR.po:
        * sr.po:
        * sr@Latn.po:
        * th.po:
        * vi.po:
        * zh_HK.po:
        * zh_TW.po: Re-add the "Time seek bar" string