GNOME Bugzilla – Bug 454151
SPC plugin enhancements (patch)
Last modified: 2008-05-20 09:02:13 UTC
The SPC decoder element was lacking several essential features such as seeking, reading the song duration from the tags and enforcing it, and support for extended tags. This patch brings the plugin up to feature parity with most other formats (except for tag writing).
Created attachment 91288 [details] [review] Feature enhancement patch for SPC decoder element
Thanks, committed your patch with some minor changes: - used GST_SECOND and GST_MSECOND instead of large integer constants everywhere - no // comments - correctly reference the taglist (i.e. not taking another reference before posting it by creating an event from it) - check values before passing the to g_date_new_dmy() 2008-05-20 Sebastian Dröge <slomo@circular-chaos.org> Patch by: Brian Koropoff <brianhk at cs dot washington dot edu> * ext/spc/Makefile.am: * ext/spc/gstspc.c: (gst_spc_dec_class_init), (gst_spc_dec_src_query_type), (gst_spc_dec_init), (gst_spc_dec_dispose), (gst_spc_dec_sink_event), (gst_spc_duration), (gst_spc_fadeout), (gst_spc_dec_src_event), (gst_spc_dec_src_query), (spc_play), (spc_setup): * ext/spc/gstspc.h: * ext/spc/tag.c: (spc_tag_is_extended), (spc_tag_is_text_format), (spc_tag_is_present), (spc_tag_unpack_date), (spc_tag_clear), (spc_tag_get_info), (spc_tag_free): * ext/spc/tag.h: Add support for some essential features like seeking, reading song duration and extended tags. Fixes bug #454151.