After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 453234 - evince-0.8.2 does not build against poppler-0.5.4
evince-0.8.2 does not build against poppler-0.5.4
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: PDF
0.8.x
Other Linux
: Normal blocker
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-07-02 21:51 UTC by Joseph Sacco
Modified: 2007-07-04 13:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Description Joseph Sacco 2007-07-02 21:51:48 UTC 
Found a typo in backends/pdf/ev-poppler.cc that prevents evince from building against the latest stable version of poppler.  The fix is shown below.

-Joseph

===========================================================
--- evince-0.8.2/backend/pdf/ev-poppler.cc-     2007-07-02 17:32:21.000000000 -0400
+++ evince-0.8.2/backend/pdf/ev-poppler.cc      2007-07-02 17:36:56.000000000 -0400
@@ -1624,7 +1624,7 @@
                                           width, height);
        }

-#if POPPLER_VERSION == 5
+#if POPPLER_VERSION == 4
        poppler_page_render_selection (POPPLER_PAGE (rc->data),
                                       rc->scale, rc->rotation, *pixbuf,
                                       (PopplerRectangle *)points,
@@ -1636,7 +1636,7 @@
                                                 rc->scale, rc->rotation, *pixbuf,
                                                 (PopplerRectangle *)points,
                                                 (PopplerRectangle *)old_points,
-                                                POPPLER_SELECTION_NORMAL,
+                                                PPLER_SELECTION_NORMAL,
                                                 text,
                                                 base);
 #endif
Comment 1 Joseph Sacco 2007-07-02 22:00:27 UTC 
Hmmm... Looks like I fat-fingered the file while patching it.  Grrrr...

The only thing that needs to change is the POPPLER_VERSION.

-Joseph
Comment 2 Nickolay V. Shmyrev 2007-07-03 06:45:33 UTC 
Hm, shouldn't it be <= 5 instead? There was no 0.5.5 version released but for some time poppler CVS snapshot had this version.
Comment 3 Carlos Garcia Campos 2007-07-03 07:27:23 UTC 
Oh!, sorry, my fault :-( 

Yes I think <= 5 would be better.
Comment 4 Carlos Garcia Campos 2007-07-04 13:14:11 UTC 
I've just fixed it. We should release 0.8.3 asap . . .