After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 453034 - Rhythmbox lyrics plugin does not fetch new lyrics when song changes
Rhythmbox lyrics plugin does not fetch new lyrics when song changes
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.11.x
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-07-02 08:07 UTC by Jérôme Guelfucci
Modified: 2007-08-24 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixes problem with updating lyrics on song change (391 bytes, patch)
2007-07-05 14:42 UTC, Cosimo Cecchi 		committed Details | Review

Description Jérôme Guelfucci 2007-07-02 08:07:17 UTC 
Please describe the problem:
THis was reported on Launchpad : https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/123470
by : https://bugs.launchpad.net/~sriram-iyer86

"cannot find lyrics on song change.
but reopening the lyrics window downloads the lyrics.
cached lyrics is displayed on song change not the 1's which are to be fetched from the net..
Hope you Get the point.."

Steps to reproduce:
1. Have the lyrics plugin activated
2. Play a song and open the lyrics window
3. Go to the next song


Actual results:
The new lyrics aren't fetched.

Expected results:
The lyrics window should be updated with the new lyrics.

Does this happen every time?
Yes

Other information:
Comment 1 Cosimo Cecchi 2007-07-05 14:42:17 UTC 
Hi, this was easy to fix. The function supposed to search lyrics was called with wrong arguments and always returned "No Lyrics Found" if the lyric was not already in the cache.
I'm attaching a patch to fix that.
Comment 2 Cosimo Cecchi 2007-07-05 14:42:55 UTC 
Created attachment 91241 [details] [review]
fixes problem with updating lyrics on song change
Comment 3 Nafallo Bjälevik 2007-07-26 12:52:53 UTC 
The patch is working out great for me. Please apply it to SVN :-).
Comment 4 Jonathan Matthew 2007-08-24 13:10:23 UTC 
Committed to svn.  Thanks.