After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 452232 - Unnecessary code in dogtail.i18n.loadTranslationsfromPackageMoFiles
Unnecessary code in dogtail.i18n.loadTranslationsfromPackageMoFiles
Status: RESOLVED FIXED
Product: dogtail
Classification: Deprecated
Component: Framework
CVS HEAD
Other All
: Normal trivial
: ---
Assigned To: Dogtail Maintainers
Dogtail Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-29 12:52 UTC by Alexander Todorov
Modified: 2007-07-25 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
i18n.py patch (1012 bytes, patch)
2007-06-29 12:55 UTC, Alexander Todorov 		none Details | Review
check for dupes (620 bytes, patch)
2007-06-29 16:33 UTC, Zack Cerza 		committed Details | Review

Description Alexander Todorov 2007-06-29 12:52:31 UTC 
Please describe the problem:
In the function dogtail.i18n.loadTranslationsfromPackageMoFiles there is a local dictionary variable moFiles. The comment for it is:
# Keep a list of mo-files that are already in use to avoid duplicates.
while the function is working new items are added to this variable but the values are never checked. The relevant code is useless.


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Alexander Todorov 2007-06-29 12:55:42 UTC 
Created attachment 90858 [details] [review]
i18n.py patch
Comment 2 Zack Cerza 2007-06-29 16:33:27 UTC 
Created attachment 90885 [details] [review]
check for dupes

You're correct about the bug, but the solution is to fix the duplicate checking, not remove it entirely.