After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 451498 - Preview of "Blank screen" is not consistent
Preview of "Blank screen" is not consistent
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: general
2.19.x
Other All
: Normal minor
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
: 568843 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-06-27 06:52 UTC by Sitsofe Wheeler
Modified: 2009-01-23 14:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Clear preview window before showing (650 bytes, patch)
2008-10-29 11:47 UTC, Neil Jagdish Patel
committed Details | Review

Description Sitsofe Wheeler 2007-06-27 06:52:18 UTC
Please describe the problem:
The blank screen preview sometimes appears grey (same colour as the toolbar panel) rather than black.

Steps to reproduce:
1. Start
gnome-screensaver-preferences
2. Select "Blank screen" in the "Screensaver theme" at the left.
3. Click the Close button.
4. Start
gnome-screensaver-preferences
5. Select "Blank screen" in the "Screensaver theme" at the left.
6. Click the Preview button.

Actual results:
Fullscreen display (other than the toolbar) appears completely grey.

Expected results:
Fullscreen display (other than the toolbar) to appear completely black.

Does this happen every time?
Yes, this happens every time.

Other information:
Reproduced on computers running ati, fglrx, i810, nv, nvidia, sis, vesa and via Xorg drivers.

Originally filed over on https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/105836 .

Version information:
Ubuntu 7.04
gnome-screensaver 2.18.1-0ubuntu1
Comment 1 Sitsofe Wheeler 2007-09-01 14:32:12 UTC
Still here on Ubuntu Gutsy.

Version information:
Ubuntu 7.10
gnome-screensaver 2.19.7-0ubuntu1
Comment 2 Sitsofe Wheeler 2008-09-14 13:08:46 UTC
Still here on Ubuntu Intrepid.

Version information:
Ubuntu 8.10
gnome-screensaver 2.23.3-0ubuntu1
Comment 3 Neil Jagdish Patel 2008-10-29 11:47:19 UTC
Created attachment 121574 [details] [review]
Clear preview window before showing

This patch should fix this bug. The preview window isn't cleared when it's shown for the blank screen screensaver, so it appears "grey" (actually its the bg[NORMAL] from the theme). It appears black the next time because it's cleared when its taken down.

The patch will clear the preview window before its shown.
Comment 4 William Jon McCann 2008-11-12 17:01:33 UTC
Thanks Neil!  Committed.
Comment 5 Michael Terry 2009-01-23 14:14:05 UTC
*** Bug 568843 has been marked as a duplicate of this bug. ***