After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 451249 - Integer type mismatch in gstrtspsrc.c
Integer type mismatch in gstrtspsrc.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal major
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-26 13:46 UTC by Tommi Myöhänen
Modified: 2007-06-27 11:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstrtspsrc.c.patch (594 bytes, patch)
2007-06-26 13:46 UTC, Tommi Myöhänen 		rejected Details | Review

Description Tommi Myöhänen 2007-06-26 13:46:02 UTC 
When setting rtspsrc caps the field "clock-base" has type G_TYPE_UINT, but in fact the value is guint64.
Comment 1 Tommi Myöhänen 2007-06-26 13:46:48 UTC 
Created attachment 90664 [details] [review]
gstrtspsrc.c.patch
Comment 2 Sebastian Dröge (slomo) 2007-06-26 17:59:39 UTC 
Hmm... you're right but changing this would break ABI I guess :/
Comment 3 Wim Taymans 2007-06-27 11:36:45 UTC 
The real valid range for clock-base is 32 bits unsigned, we declared it as uint64 internally to be able to mark an uninitialised value with -1. 

following patch explicitly casts the value on the stack as to not cause runtime problems due to different sizes.

        * gst/rtsp/gstrtspsrc.c: (gst_rtspsrc_configure_caps):
        Cast stack args to the proper types. Fixes #451249.