GNOME Bugzilla – Bug 450984
No Feedback to User when Saving a Custom Report
Last modified: 2018-06-29 21:40:37 UTC
Please describe the problem: If a user saves a custom report, there is absolutely no feedback to them that the report has been saved successfully. There is no dialog offered. The Custom Reports Menu is not updated. The Add Report button remains active. This is especially problematic due to other issues with the reports system--in particular, the fact that duplicate reports cause GC to hang on subsequent startup and also that there is no easy way for an end user to remove the extra report. (Opening the saved-reports-2.0 file in the hidden .gnucash directory, navigating the arcana of scheme to find the duplicate, and then removing these lines is not easy and shouldn't be required of typical end users). Steps to reproduce: 1. Load a report 2. Customize it (renaming etc.) 3. Click Add Report button 4. Nothing seems to happen, so 5. Click Add Report button again 6. Close and restart GC Actual results: Duplicate reports entries get made in saved-reports-2.0 Expected results: After step 3 above, 1) a dialog says "Report Saved." (a preference could control this), 2) the Add Report button greys out, and 3) the Custom Reports menu includes the new report Does this happen every time? Yes Other information: Mac OS X 10.4.9 Intel Apple's X11 11 1.1.3 GC 2.0.5
Good point. The easiest user feedback would be another message window saying "The report 'xxx' has been saved successfully and will be available at the next startup."
I *believe* that 2.1.x will not behave in this way, as on the second save, it will detect the name conflict; I'm not 100% sure, or sure what will happen when it does. Adding the menu at that point is – of course – blindingly obvious, but (like too many things in gnucash) non-trivial to do. We only construct the menu (and the data-structures that back it) at startup time, and there's no obvious way to insert a single item. :( Disabling the save button is actually, I think, incorrect given the ability to further change and re-name the report.
Disabling the button would be appropriate if the report has not been changed. It seems to me the button should be active only if the report values have been changed.
User feedback dialog is implemented in r16221. Greying out the button again is implemented in r16222. Both will be in 2.1.5 this weekend.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=450984. Please update any external references or bookmarks.