After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 450074 - crash in Remote Desktop: starting /usr/bin/vino-p...
crash in Remote Desktop: starting /usr/bin/vino-p...
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Preferences Dialog
unspecified
Other All
: High critical
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-06-22 14:10 UTC by Florian Steinel
Modified: 2007-06-28 15:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Remove suprious assertions when accessing gnome-keyring (1.06 KB, patch)
2007-06-27 14:34 UTC, Stef Walter 		none Details | Review
Remove suprious assertions when accessing gnome-keyring (1.10 KB, patch)
2007-06-27 15:15 UTC, Stef Walter 		committed Details | Review

Description Florian Steinel 2007-06-22 14:10:48 UTC 
Version: 2.18.1

What were you doing when the application crashed?
starting /usr/bin/vino-preferences


Distribution: Gentoo Base System release 1.12.9
Gnome Release: 2.19.4 2007-06-18 (Gentoo)
BugBuddy Version: 2.18.1

System: Linux 2.6.20-gentoo-r8 #1 Tue May 22 20:41:31 CEST 2007 i686
X Vendor: The X.Org Foundation
X Vendor Release: 70200000
Selinux: No
Accessibility: Disabled
GTK+ Theme: eXperience-olive
Icon Theme: gnome

Memory status: size: 32899072 vsize: 32899072 resident: 16289792 share: 8519680 rss: 16289792 rss_rlim: 4294967295
CPU usage: start_time: 1182518145 rtime: 36 utime: 30 stime: 6 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 100

Backtrace was generated from '/usr/bin/vino-preferences'

Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1238124848 (LWP 31386)]
0xb7f47410 in __kernel_vsyscall ()

+ Trace 142906

Thread 1 (Thread -1238124848 (LWP 31386))

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/libpthread.so.0
  • #2 libgnomeui_segv_handle
    at gnome-ui-init.c line 865
  • #3 <signal handler called>
  • #4 IA__g_logv
  • #5 IA__g_log
  • #6 IA__g_assert_warning
    at gmessages.c line 552
  • #7 main
    at vino-preferences.c line 108
  • #0 __kernel_vsyscall 


----------- .xsession-errors (44 sec old) ---------------------
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:332: Include-Datei konnte nicht gefunden werden: »tweaks/file-list«
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:334: Include-Datei konnte nicht gefunden werden: »tweaks/apply_styles«
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:343: error: invalid string constant "FileChooser", expected valid string constant
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:332: Include-Datei konnte nicht gefunden werden: »tweaks/file-list«
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:334: Include-Datei konnte nicht gefunden werden: »tweaks/apply_styles«
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:343: error: invalid string constant "FileChooser", expected valid string constant
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:332: Include-Datei konnte nicht gefunden werden: »tweaks/file-list«
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:334: Include-Datei konnte nicht gefunden werden: »tweaks/apply_styles«
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:343: error: invalid string constant "FileChooser", expected valid string constant
** ERROR **: file vino-preferences.c: line 108 (vino_preferences_dialog_get_password_from_keyring): assertion failed: (matches != NULL && matches->data != NULL)
aborting...
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:332: Include-Datei konnte nicht gefunden werden: »tweaks/file-list«
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:334: Include-Datei konnte nicht gefunden werden: »tweaks/apply_styles«
/usr/share/themes/eXperience-olive/gtk-2.0/gtkrc:343: error: invalid string constant "FileChooser", expected valid string constant
--------------------------------------------------
Comment 1 Sebastien Bacher 2007-06-27 09:29:37 UTC 
Ubuntu bug https://bugs.launchpad.net/vino/+bug/122009
Comment 2 Sebastien Bacher 2007-06-27 09:59:08 UTC 
Reassigning to gnome-keyring, the code didn't change and worked correctly using gnome-keyring 2.18
Comment 3 Stef Walter 2007-06-27 14:32:49 UTC 
Crashing on a null GList is always a bug. Will attach a patch for vino.

The old behavior of libgnome-keyring (returning 'DENIED' when no results were found) caused usability problems for users.
Comment 4 Stef Walter 2007-06-27 14:34:07 UTC 
Created attachment 90753 [details] [review]
Remove suprious assertions when accessing gnome-keyring
Comment 5 Stef Walter 2007-06-27 15:15:32 UTC 
Created attachment 90759 [details] [review]
Remove suprious assertions when accessing gnome-keyring

In fact, asserting another libraries return values, isn't what assertions are for: http://developer.gnome.org/doc/guides/programming-guidelines/robust.html
Comment 6 Mark McLoughlin 2007-06-28 06:53:23 UTC 
Uggh, indeed, but g_return_val_if_fail() is for preconditions ... and this case clearly isn't a pre-condition either, though.

Just check matches->data in the if statement and go ahead and commit. Thanks,

Note, we don't actually recommend using Vino's gnome-keyring support:

   http://bugzilla.gnome.org/show_bug.cgi?id=344839#c19
Comment 7 Stef Walter 2007-06-28 15:04:32 UTC 
Yes, gnome-keyring doesn't seem like such a match for the serverside password. However on the client side, it's a match made in heaven :)


2007-06-27  Stef Walter  <stef@memberwebs.com>

	* capplet/vino-preferences.c: 
	* server/vino-server.c: Don't assert on a NULL find result from 
	  gnome-keyring. Closes bug #450074