After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 449414 - [capsfilter] Copy of passed GstCaps taken instead of reference
[capsfilter] Copy of passed GstCaps taken instead of reference
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: 0.10.14
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-20 09:49 UTC by Tim Angus
Modified: 2007-06-27 11:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Patch to take a reference instead of a copy when setting "caps" (1.14 KB, patch)
2007-06-20 09:50 UTC, Tim Angus 		committed Details | Review

Description Tim Angus 2007-06-20 09:49:29 UTC 
Please describe the problem:
<Timbo> if you're fiddling with documentation you might also change http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer-plugins/html/gstreamer-plugi
ns-capsfilter.html to say that settings the caps property takes a copy of your GstCaps, not a reference :)
<thaytan> Timbo: it'd be better to fix capsfilter to take a reference, not a copy ;)



Steps to reproduce:
1. Employ a capsfilter element
2. Set "caps" property
3. Notice no reference taken on GstCaps object passed


Actual results:
No reference is taken on the GstCaps object passed to the capsfilter element

Expected results:
A reference to be taken on the GstCaps object passed to the capsfilter element

Does this happen every time?
Yes

Other information:
Comment 1 Tim Angus 2007-06-20 09:50:08 UTC 
Created attachment 90325 [details] [review]
Patch to take a reference instead of a copy when setting "caps"
Comment 2 Wim Taymans 2007-06-27 11:24:24 UTC 
        Patch by: Tim Angus <tim at ngus dot net>

        * plugins/elements/gstcapsfilter.c: (gst_capsfilter_class_init),
        (gst_capsfilter_set_property):
        Take a reference instead of a copy when setting "caps".
        Fix documentation to clarify this behaviour. Fixes #449414.