GNOME Bugzilla – Bug 449232
Firefox move to next large object tweak
Last modified: 2008-07-22 19:27:57 UTC
Navigate to next large object should be tweaked so text less than a certain length is skipped. Currently go to next/previous chunk stops at headings, paragraphs, tables (not layout), text, and autocomplete boxes, but text length is not considered.
Created attachment 90291 [details] [review] first version of Firefox move to next large object tweak Now moving to headings, text, section, document frame, paragraph, table, table cell and autocomplete only if they implement the text interface and have text with length greater than 75.
(In reply to comment #1) > Created an attachment (id=90291) [edit] > first version of Firefox move to next large object tweak > > Now moving to headings, text, section, document frame, paragraph, table, table > cell and autocomplete only if they implement the text interface and have text > with length greater than 75. Looks like a good way to help identify a chunk. I like the use of the predicate as well. If you could make a smallish change, I'd request that the 75 be made a constant in the file somewhere up around the same spot controlCaretNavigation is defined for the first time. Maybe "largeObjectTextLength" or something. This would allow someone to then override its value from their user-settings.py file. It would also set us up for allowing it to be customized via the GUI, but I like the idea of not exposing it via the customization GUI at this point in time.
So far this is looking like a nice improvement. I've still got quite a few more sites I want to test on though. More feedback tomorrow.
Created attachment 90332 [details] [review] second version of move to next large object tweak largeObjectTextLength constant now defined, however, it was only used in the match predicate. Do I need to do anything else with it, perhaps in setAppPreferences()?
Personally I think this patch is a big improvement over what we had before. It is stopping where I would expect with out a lot of false possitives.
> largeObjectTextLength constant now defined, however, it was only used in the > match predicate. Do I need to do anything else with it, perhaps in > setAppPreferences()? Thanks! For now, I think just making it a user-modifiable constant is fine. This will allow more sophisticated users to more easily play around with the value and give us informed feedback. If users ultimately request the ability to customize the value, we can then go through the exercise of making it available via the preferences GUI. Thanks! PS - If you can get rid of the "\ No newline at end of file" part, that would be great.
committed to repository
Overall this feature is now working great. I've found one site however that doesn't behave well. 1. Open www.sfgate.com 2. Press "o" to move through the page. 3. At the bottom press "shift+o" to move back up the page. What you should notice when moving both directions is that most things will be read as expected but at perhaps 6 places orca will speak nothing when it stops.
Created attachment 90817 [details] [review] third version of move to next large object tweak Additional tweak. Thanks Joanie!