After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 449226 - Incomplete ghostpads in xml session save
Incomplete ghostpads in xml session save
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.6
Other All
: Normal minor
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-19 18:28 UTC by Étienne Noreau-Hébert
Modified: 2007-06-27 09:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds missing fields for ghostpads to XML pipeline descriptions (1.78 KB, patch)
2007-06-19 18:29 UTC, Étienne Noreau-Hébert
committed Details | Review

Description Étienne Noreau-Hébert 2007-06-19 18:28:21 UTC
Please describe the problem:
Ghostpads are reported with parent and names attributes only, lacking peer and direction.

Steps to reproduce:
1. gst-launch-0.10 -o foo.xml videotestsrc ! videoscale ! video/x-raw-yuv,width=320,height=240 ! ffmpegcolorspace ! ffenc_mpeg4 ! rtpmp4vpay send-config=true mtu=2048 pt=97 ssrc=123456 timestamp-offset=20619 seqnum-offset=44441 ! identity sync=true !  rtpbin rtcp-support=true localport=9424 destinations=172.16.2.27:9424;


3. 


Actual results:
XML representation of the pipeline is missing information on the peers and direction of ghostpads
---8<---------------
        <gst:pad>
          <gst:ghostpad>
            <gst:name>sink</gst:name>
            <gst:parent>rtpbin0</gst:parent>
          </gst:ghostpad>
        </gst:pad>
        <gst:children>
          <gst:element>
----8<----------------------

Expected results:
The expected result would be something like this:
---8<---------------
        <gst:pad>
          <gst:ghostpad>
            <gst:name>sink</gst:name>
            <gst:parent>rtpbin0</gst:parent>
            <gst:direction>sink</gst:direction>
            <gst:peer>identity0.src</gst:peer>
          </gst:ghostpad>
        </gst:pad>
        <gst:children>
          <gst:element>
----8<----------------------

Does this happen every time?
Yes.

Other information:
Comment 1 Étienne Noreau-Hébert 2007-06-19 18:29:11 UTC
I have written a patch to complete de missing fields. See gstghostpad.c.session.xml.patch in attachments...
Comment 2 Étienne Noreau-Hébert 2007-06-19 18:29:58 UTC
Created attachment 90288 [details] [review]
Adds missing fields for ghostpads to XML pipeline descriptions
Comment 3 Wim Taymans 2007-06-27 09:34:16 UTC
        Patch by: Étienne Noreau-Hébert <etienne at deepunder dot org>

        * gst/gstghostpad.c: (gst_proxy_pad_save_thyself):
        Add peer and direction in the XML serialisation of ghostpads.
        Fixes #449226.