After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 448928 - Some GtkBuildable methods named too generically
Some GtkBuildable methods named too generically
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkBuilder
2.11.x
Other Linux
: Normal blocker
: ---
Assigned To: GtkBuilder maintainers
GtkBuilder maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-18 21:45 UTC by Torsten Schoenfeld
Modified: 2007-06-19 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename add() to add_child(), set_property() to set_buildable_property() (31.85 KB, patch)
2007-06-18 21:46 UTC, Torsten Schoenfeld 		accepted-commit_now Details | Review

Description Torsten Schoenfeld 2007-06-18 21:45:54 UTC 
Some of GtkBuildable's method's have names that are too generic and thus prone to name clashes.  The attached patch renames add() to add_child() and set_property() to set_buildable_property().
Comment 1 Torsten Schoenfeld 2007-06-18 21:46:45 UTC 
Created attachment 90240 [details] [review]
Rename add() to add_child(), set_property() to set_buildable_property()
Comment 2 Johan (not receiving bugmail) Dahlin 2007-06-18 23:23:14 UTC 
Comment on attachment 90240 [details] [review]
Rename add() to add_child(), set_property() to set_buildable_property()

This looks good to me.
I hope make check passed, but I guess mclasen will find out.
Comment 3 Johan (not receiving bugmail) Dahlin 2007-06-19 12:23:52 UTC 
Sending        ChangeLog
Sending        docs/reference/gtk/gtk-sections.txt
Sending        docs/reference/gtk/tmpl/gtkbuildable.sgml
Sending        gtk/gtk.symbols
Sending        gtk/gtkactiongroup.c
Sending        gtk/gtkbuildable.c
Sending        gtk/gtkbuildable.h
Sending        gtk/gtkbuilder.c
Sending        gtk/gtkcelllayout.c
Sending        gtk/gtkcelllayout.h
Sending        gtk/gtkcellview.c
Sending        gtk/gtkcombobox.c
Sending        gtk/gtkcontainer.c
Sending        gtk/gtkentrycompletion.c
Sending        gtk/gtkexpander.c
Sending        gtk/gtkframe.c
Sending        gtk/gtkiconview.c
Sending        gtk/gtknotebook.c
Sending        gtk/gtktreeview.c
Sending        gtk/gtktreeviewcolumn.c
Sending        gtk/gtkuimanager.c
Sending        gtk/gtkwidget.c
Sending        gtk/gtkwindow.c
Transmitting file data .......................
Committed revision 18187.