After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 448610 - Activating status icon does not hide raised and focused Downloads window
Activating status icon does not hide raised and focused Downloads window
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
2.18.x
Other All
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-17 22:19 UTC by Matt Kraai
Modified: 2007-07-26 04:15 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Patch (630 bytes, patch)
2007-06-17 22:20 UTC, Matt Kraai 		committed Details | Review

Description Matt Kraai 2007-06-17 22:19:32 UTC 
Please describe the problem:
According to the draft HIG, when a status icon is activated and the window that it is associated with is already raised and focused, the window should be hidden.  Epiphany does not do this for the Downloads window.

Steps to reproduce:
1. Start downloading something (e.g., http://www.archive.org/download/wealthofnetworks/wealthofnetworks_vbr_mp3.zip).
2. Activate the Downloads status icon in the notification area.


Actual results:
The Downloads window stays visible.

Expected results:
The Downloads window would be hidden.

Does this happen every time?
Yes.

Other information:
Comment 1 Matt Kraai 2007-06-17 22:20:47 UTC 
Created attachment 90178 [details] [review]
Patch

The attached patch checks whether the Downloads window is raised and focused and, if it is, hides the window instead of presenting it.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2007-07-25 21:06:43 UTC 
Kraai do you have commit rights on SVN?
Comment 3 Matt Kraai 2007-07-26 01:50:07 UTC 
(In reply to comment #2)
> Kraai do you have commit rights on SVN?

No.  Would someone please commit the patch for me?
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2007-07-26 04:15:09 UTC 
Ok. Done :). Thanks!

2007-07-25  Diego Escalante Urrelo  <diegoe@gnome.org>

        * embed/downloader-view.c:

        Make the status icon clickable so it shows/hides the download window,
        works across workspaces. Patch by Kraai. Fixes bug #448610.