After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 448263 - drop libgnome dependency
drop libgnome dependency
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Rich Burridge
Rich Burridge
Depends on:
Blocks:
 
 
Reported: 2007-06-16 17:24 UTC by Jani Monoses
Modified: 2007-06-18 15:40 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
the patch (6.99 KB, patch)
2007-06-16 17:33 UTC, Jani Monoses
none Details | Review

Description Jani Monoses 2007-06-16 17:24:58 UTC
replace or remove the currently used libgnome calls.
Comment 1 Jani Monoses 2007-06-16 17:33:19 UTC
Created attachment 90082 [details] [review]
the patch

- replace gnome_help_display_desktop() with code from libgnome. As a bonus this ade both calls' to help error handling be consistent when by using a dialog.
- drop GnomeClient dep which is only used for die callback that does gtk_main_quit() and is useless
- use gtk_init instead of gnome_program_init. bug-buddy functionality is lost but that does not seem very important for gcalctool. There were few crashers and the last was caught months ago by ubuntu's apport not bug buddy.

This patch makes the current --enable-gnome switch redundant as the app becomes plain GTK + gconf. On the box I tested it in the number of linked DSOs dropped from 69 to 36 and startup time improved noticably.
Comment 2 Rich Burridge 2007-06-18 15:40:31 UTC
Patch committed. It'll also be in the gcalctool 
5.19.4 tarball that went out today.

Elijah Newren also commented by email yesterday:
"There were some posts somewhere about how you
could manually add bug-buddy support without using 
libgnome (may have just been cutting-and-pasting 
some code from libgnome; can't remember).  You may 
want to dig that up and use it."

After thinking about this, I'm not going to worry about
doing this. Bug-buddy isn't "smart" enough for my liking.
It causes more work not less. Witness all the duplicates
of bug #354730 I had to close recently, even though there
was already a fixed version of gcalctool available. If it
was smart enough to check if the current stack trace is
similar to one that has already been reported against this 
application ("B.B. phone home") and not generate a new bug 
in that case, then I'd think more about wanting this 
support back.

For now, closing out this bug as FIXED. Thanks Jani!