After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 447741 - Language selection causes problems with firefox's dashed locales
Language selection causes problems with firefox's dashed locales
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-06-15 02:33 UTC by Dimitris Glezos
Modified: 2007-06-16 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes language selection (565 bytes, patch)
2007-06-15 02:34 UTC, Dimitris Glezos
none Details | Review

Description Dimitris Glezos 2007-06-15 02:33:13 UTC
Please describe the problem:
Firefox returns locales with dashes (eg. pt-BR) instead of underscores (pt_BR), and so a LINGUAS file with underscored locales can't be matched against.

Steps to reproduce:
1. Add pt_BR in LINGUAS, pt_BR.po, make
2. Install Quick Locale Switcher Addon in firefox and select pt-BR

Actual results:
Pages don't show up in Brazilian Portuguese.

Expected results:


Does this happen every time?


Other information:
Attaching a patch
Comment 1 Dimitris Glezos 2007-06-15 02:34:58 UTC
Created attachment 89985 [details] [review]
Fixes language selection

So this is a quick hack to temporarily get the whole list in dashes instead of underscores. This could create a problem if you had both underscores and dashes, but we don't have that. The correct thing would be to modify the library used for matching.
Comment 2 Claude Paroz 2007-06-16 14:24:53 UTC
Fixed in rev. 387. Thanks Dimitris.