After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 447498 - clearlooks 2.10 changes the appearance of Debian installer
clearlooks 2.10 changes the appearance of Debian installer
Status: RESOLVED WONTFIX
Product: gtk-engines
Classification: Deprecated
Component: clearlooks
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-14 11:34 UTC by Loïc Minier
Modified: 2007-06-14 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Loïc Minier 2007-06-14 11:34:48 UTC
Hi there,

Frans Pop, our Debian installer maintainer, noticed some differences in the appearance of the Debian installer (which uses clearlooks) between clearlooks 2.8 and 2.10.  Please take a look at the screenshots at:
http://alioth.debian.org/~fjp-guest/tmp/clearlooks/

These show some differences in:
- color of the selected radio button
- color of a selected check box
- gradient of selected lines
- gradient of the title bar
- font

Do you think it would be possible to revert to the previous handling of these settings?

The gtkrc used in the Debian installer is at:
http://svn.debian.org/wsvn/d-i/trunk/packages/rootskel-gtk/src/usr/share/themes/Clearlooks/gtk-2.0/gtkrc?op=file&rev=0&sc=0

Bye,
Comment 1 Frans Pop 2007-06-14 12:57:46 UTC
The changes in title bar and font mentioned by Loïc were due to a change in the png we use as banner, so that can be ignored.

The main issue for this bug report is the change in color of selected checkboxes and radio buttons.

Screenshots showing the differences (using the same gtkrc and banner) can been seen at:
http://alioth.debian.org/~fjp-guest/tmp/clearlooks/


The screenshots for the checkboxes also show a change in the active line. I'm not sure where that comes from. The directfb log for "unstable" shows:
/usr/share/themes/Clearlooks/gtk-2.0/gtkrc:56: Clearlooks configuration option "menuitemstyle" is not supported and will be ignored.
/usr/share/themes/Clearlooks/gtk-2.0/gtkrc:56: Clearlooks configuration option "listviewitemstyle" is not supported and will be ignored.
/usr/share/themes/Clearlooks/gtk-2.0/gtkrc:56: Clearlooks configuration option "progressbarstyle" is not supported and will be ignored.

For "etch" these warnings are not displayed.

Because of these warnings, those configuration options are now disabled in the gtkrc in our SVN repository Loïc linked to, but they are still enabled in the gtkrc used when making these screenshots.
Comment 2 Benjamin Berg 2007-06-14 14:20:19 UTC
The options were silently ignored earlier, because they were never implemented in the cairo version of the engine. The only change is that a warning is printed now.

The check and radio buttons were changed to use text[NORMAL] instead of a color based on bg[SELECTED]. I don't remember the reason for this decision right now though. (Unfortunatly you could not even work around this in the theme for the checkboxes in the treeview)

I always had the opinion that slight changes over time should be fine. You'll also notice that the gradient in the button changed a little bit.
Comment 3 Loïc Minier 2007-06-14 14:31:28 UTC
Is there a way to express the same UI as in the past in a gtkrc syntax which would be valid for clearlooks 2.8 and 2.10?
Comment 4 Benjamin Berg 2007-06-14 15:21:53 UTC
No, there is none.
Comment 5 Loïc Minier 2007-06-14 15:31:16 UTC
Ok; is it easy for you to suggest what we need to minimally change to get similarly looking radio buttons and checkboxes as we had in the past?  Or would this require reverting the gtk-engines changes in question?
Comment 6 Benjamin Berg 2007-06-14 15:41:37 UTC
It is pretty simple for the normal check and radio buttons. But unfortunately I think it is impossible in the treeview, as you would end up also changing the normal text color.

For the checkboxes something like

style "check-and-radio" {
    text[NORMAL] = "#ff0000" # your color
}
class "GtkCheckButton" style "check-and-radio"

would work. But that doesn't help you really ...
Comment 7 Andrea Cimitan 2007-06-14 18:37:07 UTC
I'm the man who changed those colors :)
The change was done to improve usability with every themes, since a lot of colors (not as you red) were not very visible. Using text[NORMAL] is defenitely looking more usable and imho "better", in most cases.

To do a simple modification I can suggest you to follow benzea's instructions, and I agree that it seems difficult to me to get the right color inside the treeview.

Probably you should try using the widget_class section and finding gtkcheck (???)

In that case you should only try... But i suggesto you to use the black :D

Marking as "WONTFIX"
Comment 8 Andrea Cimitan 2007-06-14 18:46:58 UTC
Oh yes there's an horrible hack! :D
You could use the pixbuf engine and use a pixmap for the checks... this will work also inside the treeview, just copy the checks for old clearlooks (with gimp) and use them as new checkboxes.
But you need pixbuf engine (gtk2-engines-pixbuf or something like this in debian) and you need to edit the gtkrc in the correct way