After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 447458 - [qtdemux] export AMRSpecificBox as codec_data
[qtdemux] export AMRSpecificBox as codec_data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-14 10:09 UTC by Edward Hervey
Modified: 2007-06-14 10:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (973 bytes, patch)
2007-06-14 10:12 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2007-06-14 10:09:42 UTC 
Although the reference amr decoder shipped with gst-plugins doesn't need out-of-band information to properly decode AMR-NB streams, some other decoders need it.

This information should be exported by qtdemux as a codec_data field in the caps.
Comment 1 Edward Hervey 2007-06-14 10:12:02 UTC 
Created attachment 89938 [details] [review]
proposed patch

Export 'damr' atom box contained in the 'stsd' atom of the AMR-NB track.

This will set that buffer as a 'codec_data' property of the caps.
Comment 2 Jan Schmidt 2007-06-14 10:18:37 UTC 
Since I have to do a new pre-release for -good anyway, I'll reopen the window for non-regression non-destabilising patches. Go for it.
Comment 3 Edward Hervey 2007-06-14 10:23:48 UTC 
thx,

2007-06-14  Edward Hervey  <edward@fluendo.com>

	* gst/qtdemux/qtdemux.c: (qtdemux_parse_trak):
	For AMR-NB streams, export the AMRSpecificBox as codec_data on the
	caps.
	Fixes #447458