After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 446981 - error during the compilation of rtspconnection.c
error during the compilation of rtspconnection.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal blocker
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-13 03:37 UTC by Vincent Torri
Modified: 2007-06-15 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix MinGW compilation of rtspconnection.c (2.37 KB, patch)
2007-06-13 16:46 UTC, Vincent Torri
none Details | Review

Description Vincent Torri 2007-06-13 03:37:48 UTC
with MinGW, I have those errors:

rtspconnection.c: In function `rtsp_connection_connect':
rtspconnection.c:214: warning: implicit declaration of function `fcntl'
rtspconnection.c:214: error: `F_SETFL' undeclared (first use in this function)
rtspconnection.c:214: error: (Each undeclared identifier is reported only once
rtspconnection.c:214: error: for each function it appears in.)
rtspconnection.c:214: error: `O_NONBLOCK' undeclared (first use in this function)
rtspconnection.c:220: error: `EINPROGRESS' undeclared (first use in this function)

If I'm not mistaken, that fcntl call (see also lines 139 and 140) can be replaced on windows by:

ioctlsocket(fd, FIONBIO, &flags)

where flags is declared like that:

unsigned long flags;

To check the returned value of ioctlsocket : 

if (ioctlsocket(svr->fd, FIONBIO, &flags) == SOCKET_ERROR) { *** }


about line 220, EINPROGRESS is actually WSAEINPROGRESS, defined in winsock2.h. So maybe a #define EINPROGRESS WSAEINPROGRESS just after including winsock2.h is sufficient.

If you think that those modifications are correct, I can make a patch
Comment 1 Wim Taymans 2007-06-13 08:55:40 UTC
If you make a patch, we can still apply it before the release.
Comment 2 Jan Schmidt 2007-06-13 09:16:56 UTC
I'll make a first pre-release without it and hope you can have a patch ready in the next few days.
Comment 3 Vincent Torri 2007-06-13 16:46:04 UTC
Created attachment 89891 [details] [review]
fix MinGW compilation of rtspconnection.c
Comment 4 Jan Schmidt 2007-06-14 10:22:57 UTC
Looks good, and works for me on Linux. This will work with the VS builds too, right?
Comment 5 Sebastien Moutte 2007-06-14 21:51:57 UTC
yes, it's building with Visual Studio.
Comment 6 Jan Schmidt 2007-06-15 08:33:09 UTC
Thanks for confirming. Committed:

2007-06-15  Jan Schmidt  <thaytan@mad.scientist.com>

        * gst/rtsp/rtspconnection.c: (rtsp_connection_create),
        (rtsp_connection_connect):
        Fix the MingW build.
        Patch By: Vincent Torri <vtorri at univ-evry dot fr>
        Fixes: #446981