GNOME Bugzilla – Bug 446902
[queue2] Define minimum buffering message steps
Last modified: 2009-09-10 08:17:47 UTC
To avoid a continuous posting of messages to the bus while buffering, queue2 should offer a property to set a minimum difference between buffering messages posted. Suppose it has just posted 5%, so if this message-step property is set to 10, it will only post another message when the buffering is at least 15%.
Created attachment 89846 [details] [review] Adds the functionality. Creates the property buffering-message-step and add the code to do what the enhancement proposes.
Looks good in general but what exactly is the NOT_BUFFERING constant about? If the last message is set to this you will always post a message because the diff is always larger than 100 unless I miss anything here... and this means that messages will be posted in any case and forever if 100% is reached.
You're right, the patch has a bug. But this has been proposed a long time ago when queue2 was still being developed (or almost finishing its development) and no one bothered about it. If this issue is relevant I can send an updated patch, but I think that no one cares about this, so, closing it is also an option.
Then let's close this because nobody cares anymore ;)