GNOME Bugzilla – Bug 445865
Some strings are not marked for translation
Last modified: 2007-07-26 15:04:15 UTC
Please describe the problem: Several strings are not marked for translation in the gnome/vpn-properties/nm-vpn-properties.c file. Most of these were introduced in this revision: http://svn.gnome.org/viewcvs/NetworkManager?view=revision&revision=1947 and the descriptions coming after the --help command were never translated. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 89662 [details] [review] Trivial fix
Comment on attachment 89662 [details] [review] Trivial fix Hi, thanks for the patch. >@@ -1024,27 +1024,27 @@ > /* Druid Page 1 - Create VPN Connection */ > druid_start_page = GNOME_DRUID_PAGE_EDGE ( > gnome_druid_page_edge_new_with_vals( >- GNOME_EDGE_START, TRUE, "Create VPN Connection", >- "This assistant will guide you through the creation of a connection to " >+ GNOME_EDGE_START, TRUE, _("Create VPN Connection"), >+ _("This assistant will guide you through the creation of a connection to " > "a Virtual Private Network (VPN).\n\nIt will require some information, " > "such as IP addresses and secrets. Please see your system administrator " >- "to obtain this information.", NULL, NULL, NULL)); >+ "to obtain this information."), NULL, NULL, NULL)); Strings marked for translation shouldn't have non-translatable strings in them. Please rework this so that \n\n is not part of the translation. > gnome_druid_page_edge_set_bg_color(druid_start_page,&druid_color); > gnome_druid_page_edge_set_logo_bg_color(druid_start_page,&druid_color); > > /* Druid Page 2 - Select Connection Type */ > druid_conn_type_page = GNOME_DRUID_PAGE_STANDARD ( >- gnome_druid_page_standard_new_with_vals("Create VPN Connection - 1 of 2",NULL, NULL)); >+ gnome_druid_page_standard_new_with_vals(_("Create VPN Connection - 1 of 2"),NULL, NULL)); > gnome_druid_page_standard_set_background(druid_conn_type_page,&druid_color); > gnome_druid_page_standard_set_logo_background(druid_conn_type_page,&druid_color); > gnome_druid_page_standard_append_item(druid_conn_type_page, >- "Choose which type of VPN connection you wish to create:", >+ _("Choose which type of VPN connection you wish to create:"), > GTK_WIDGET(vpn_type_combo_box), NULL); > gtk_signal_connect_after (GTK_OBJECT (druid_conn_type_page), "next", GTK_SIGNAL_FUNC (vpn_druid_vpn_type_page_next), NULL); > > /* Druid Page 3 - Connection Details */ > druid_details_page = GNOME_DRUID_PAGE_STANDARD ( >- gnome_druid_page_standard_new_with_vals("Create VPN Connection - 2 of 2",NULL, NULL)); >+ gnome_druid_page_standard_new_with_vals(_("Create VPN Connection - 2 of 2"),NULL, NULL)); Would it be worth factoring this out so that the localizer only has to translate "Create VPN Connection" once, and then 1 of 2 and 2 of 2? > gnome_druid_page_standard_set_background(druid_details_page,&druid_color); > gnome_druid_page_standard_set_logo_background(druid_details_page,&druid_color); > gtk_signal_connect_after (GTK_OBJECT (druid_details_page), "prepare", GTK_SIGNAL_FUNC (vpn_druid_vpn_details_page_prepare), NULL); >@@ -1055,7 +1055,7 @@ > /* Druid Page 4 - FInished Create VPN Connection */ > druid_confirm_page = GNOME_DRUID_PAGE_EDGE ( > gnome_druid_page_edge_new_with_vals( >- GNOME_EDGE_FINISH, TRUE, "Finished Create VPN Connection", >+ GNOME_EDGE_FINISH, TRUE, _("Finished Create VPN Connection"), > "", NULL, NULL, NULL)); > gnome_druid_page_edge_set_bg_color(druid_confirm_page,&druid_color); > gnome_druid_page_edge_set_logo_bg_color(druid_confirm_page,&druid_color); >@@ -1121,8 +1121,8 @@ > gchar *import_svc = NULL; > gchar *import_file = NULL; > GOptionEntry entries[] = { >- { "import-service", 's', 0, G_OPTION_ARG_STRING, &import_svc, "VPN Service for importing", NULL}, >- { "import-file", 'f', 0, G_OPTION_ARG_FILENAME, &import_file, "File to import", NULL}, >+ { "import-service", 's', 0, G_OPTION_ARG_STRING, &import_svc, _("VPN Service for importing"), NULL}, >+ { "import-file", 'f', 0, G_OPTION_ARG_FILENAME, &import_file, _("File to import"), NULL}, > { NULL } > }; > >@@ -1130,7 +1130,7 @@ > bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8"); > textdomain (GETTEXT_PACKAGE); > >- context = g_option_context_new ("- NetworkManager VPN properties"); >+ context = g_option_context_new (_("- NetworkManager VPN properties")); The leading - is probably not something we want translated.
>- context = g_option_context_new ("- NetworkManager VPN properties"); >+ context = g_option_context_new (_("- NetworkManager VPN properties")); In fact you shouldn't translate this at all, just mark it with N_(), and then use g_option_context_set_translation_domain().
Created attachment 90061 [details] [review] Updated patch
fixed in trunk, thanks