After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 444610 - Only part of cell range highlighted when clicking inside entry toolbar
Only part of cell range highlighted when clicking inside entry toolbar
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.7.x
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2007-06-06 06:37 UTC by Daniel Vianna
Modified: 2007-06-08 04:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sample gnumeric file which shows the problem (2.91 KB, application/octet-stream)
2007-06-06 06:39 UTC, Daniel Vianna
Details
screenshot showing the mismatch between formula and highlight (143.18 KB, image/png)
2007-06-06 06:46 UTC, Daniel Vianna
Details
System info, with gcc version, etc. (8.83 KB, text/plain)
2007-06-06 21:19 UTC, Daniel Vianna
Details

Description Daniel Vianna 2007-06-06 06:37:34 UTC
Please describe the problem:
When I select a range within a formula (from the entry toolbar), a cell range should be highlighted, which matches the actual range in the formula. I've noticed that whenever the range goes beyond two cells not displayed (because there's no space in the display to show everything), the remaining range is not highlighted when I scroll down the spreadsheet display.

While the formula result is correct, that makes it more difficult to access its correctness (as I can't believe that the highlighted area corresponds to the real selected range).

Steps to reproduce:
1. make a long vertical series of cells with numbers
2. in the top cell, make a formula which includes many cells which are beyond the visible area of the display
3. scroll down and check if the highlighted cells match the formula range parameter.


Actual results:
The highlighted area does not match the range in the formula

Expected results:
They should match

Does this happen every time?
Yes

Other information:
Comment 1 Daniel Vianna 2007-06-06 06:39:16 UTC
Created attachment 89452 [details]
sample gnumeric file which shows the problem

I have included the data where I found the bug in this file. I hope it makes the point clear.
Comment 2 Daniel Vianna 2007-06-06 06:46:32 UTC
Created attachment 89453 [details]
screenshot showing the mismatch between formula and highlight

Notice the mismatch between formula and highlighted cell range
Comment 3 Jody Goldberg 2007-06-06 17:35:59 UTC
Interesting, I can not replicate.  What version are you using ?
Comment 4 Daniel Vianna 2007-06-06 21:17:42 UTC
I'm using 1.7.10, in a Gentoo system. I noticed also that if I scroll down, so the intended range is completely out of sight, then click in the formula, then scroll back, nothing is highlighted at all. I'm attaching a text file with the gentoo compile+system information.
Comment 5 Daniel Vianna 2007-06-06 21:19:58 UTC
Created attachment 89510 [details]
System info, with gcc version, etc.

Information about my compiling environment (Gentoo). That's the output of the Gentoo-specific command # emerge --info
Comment 6 Andreas J. Guelzow 2007-06-06 23:15:57 UTC
I can replicate this.
Comment 7 Morten Welinder 2007-06-07 14:12:31 UTC
I see it too.
Comment 8 Morten Welinder 2007-06-07 18:38:24 UTC
In item_cursor_update, we clip to visible region.  I am not sure why.

Unrelatedly, in item_cursor_bound_set, it looks like the two sides of &&
ought to be reversed.
Comment 9 Andreas J. Guelzow 2007-06-07 20:06:17 UTC
If memory serves me right, there used to be a problem relating to a gtk issue with  rectangles that are to large.
Comment 10 Jody Goldberg 2007-06-08 03:10:01 UTC
#9 : It was a bug in some X servers that would freeze up allocating massive amounts of memory trying to render a cursor for a full column.

#8 : agreed.  I'll add that to the patch.

#1 Ahhh I see, you scrolled down with the scrollbar while editing.
The logic here seems wonky.  We should be clipping the region in _draw, not in _update.  Now I just need to remind myself how this code works.
Comment 11 Jody Goldberg 2007-06-08 04:26:11 UTC
Looks like we were clipping twice.
Fixed for 1.7.11