After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 444514 - [PATCH] dvdsubdec miscalculates (long) subtitle durations
[PATCH] dvdsubdec miscalculates (long) subtitle durations
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
0.10.5
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-05 21:20 UTC by Mark Nauwelaerts
Modified: 2007-06-05 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simple possible patch (721 bytes, patch)
2007-06-05 21:23 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2007-06-05 21:20:40 UTC 
At some point, dvdsubdec uses a guint to store subtitle duration.
This is not quite by the book, and typically, this can but hold up to (very roughly) 4 sec, so subtitles with longer duration are overflowed/cut short.
Comment 1 Mark Nauwelaerts 2007-06-05 21:23:25 UTC 
Created attachment 89438 [details] [review]
Simple possible patch

* Use GstClockTime for a time/duration variable, not guint
Comment 2 Sebastian Dröge (slomo) 2007-06-05 21:47:48 UTC 
Thanks for the patch, fixed in CVS:

2007-06-05  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by by: Mark Nauwelaerts <manauw at skynet dot be>

	* gst/dvdsub/gstdvdsubdec.c: (gst_dvd_sub_dec_parse_subpic):
	Use GstClockTime instead of guint for a time variable to prevent
	overflows on too large subtitle durations. Fixes #444514.