After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 444257 - remove libgnomecanvas from gail dependence.
remove libgnomecanvas from gail dependence.
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal critical
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2007-06-05 08:18 UTC by Li Yuan
Modified: 2007-06-25 02:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (414 bytes, patch)
2007-06-05 08:20 UTC, Li Yuan
none Details | Review

Description Li Yuan 2007-06-05 08:18:58 UTC
gail doesn't depend on libgnomecanvas any more, so we need to remove the dependence.
Comment 1 Li Yuan 2007-06-05 08:20:44 UTC
Created attachment 89394 [details] [review]
patch
Comment 2 Frederic Peters 2007-06-05 09:06:05 UTC
Thanks for the notice; note that the change should have been made to modulesets/gnome-suites-2.20.modules instead of scripts/gnome-2.6.deps.

2007-06-05  Frederic Peters  <fpeters@0d.be>

       * modulesets/gnome-suites-2.20.modules: removed dependency from
       gail to libgnomecanvas (closes: #444257)

Comment 3 Sven Herzberg 2007-06-21 11:21:42 UTC
Why? Why? Why?

2007-06-20  Elijah Newren  <newren gmail com>

        * modulesets/gnome-suites-2.20.modules:
        gail depends on libgnomecanvas

        * modulesets/gnome-external-deps-2.20.modules:
        Update shared-mime-info and libmusicbrainz version numbers.
Comment 4 Sven Herzberg 2007-06-21 12:41:02 UTC
This is everything about "canvas" that grep found in source files:
gail/gail.c-110-                                gboolean  *transient)
gail/gail.c-111-{
gail/gail.c-112-  AtkObject *obj = NULL;
gail/gail.c:113:  GType gnome_canvas;
gail/gail.c-114-
gail/gail.c:115:  gnome_canvas = g_type_from_name ("GnomeCanvas");
gail/gail.c-116-
gail/gail.c-117-  *transient = FALSE;
gail/gail.c-118-  if (!widget)
--
gail/gail.c-147-          g_object_unref (obj);
gail/gail.c-148-        }
gail/gail.c-149-    }
gail/gail.c:150:  else if (GTK_CHECK_TYPE ((widget), gnome_canvas))
gail/gail.c-151-    {
gail/gail.c-152-      GObject *focused_item;
gail/gail.c-153-

So, please remove the canvas dependency again.
Comment 5 Elijah Newren 2007-06-22 01:08:27 UTC
Oh sorry.  I noticed that in the latest gail tarball that a dependency was needed, so I added it to the tarball moduleset and thought I'd be a good citizen and add it to the svn moduleset for everyone.  Oops.  :-/

This was just a careless mistake on my part for applying it to svn without double-checking; sorry about that.  I've reverted it.
Comment 6 Li Yuan 2007-06-22 07:36:02 UTC
Hi Sven, as you can see in the these code, we don't need to depend on libgnome-canvas. We get the type from a string.
Comment 7 Elijah Newren 2007-06-24 00:18:59 UTC
Li: It'd be awesome to get a new atk tarball that doesn't have the libgnomecanvas dependency.  ;-)
Comment 8 Li Yuan 2007-06-25 02:06:56 UTC
Sure. I will release 1.19.5 when gnome2.19.5