GNOME Bugzilla – Bug 444257
remove libgnomecanvas from gail dependence.
Last modified: 2007-06-25 02:06:56 UTC
gail doesn't depend on libgnomecanvas any more, so we need to remove the dependence.
Created attachment 89394 [details] [review] patch
Thanks for the notice; note that the change should have been made to modulesets/gnome-suites-2.20.modules instead of scripts/gnome-2.6.deps. 2007-06-05 Frederic Peters <fpeters@0d.be> * modulesets/gnome-suites-2.20.modules: removed dependency from gail to libgnomecanvas (closes: #444257)
Why? Why? Why? 2007-06-20 Elijah Newren <newren gmail com> * modulesets/gnome-suites-2.20.modules: gail depends on libgnomecanvas * modulesets/gnome-external-deps-2.20.modules: Update shared-mime-info and libmusicbrainz version numbers.
This is everything about "canvas" that grep found in source files: gail/gail.c-110- gboolean *transient) gail/gail.c-111-{ gail/gail.c-112- AtkObject *obj = NULL; gail/gail.c:113: GType gnome_canvas; gail/gail.c-114- gail/gail.c:115: gnome_canvas = g_type_from_name ("GnomeCanvas"); gail/gail.c-116- gail/gail.c-117- *transient = FALSE; gail/gail.c-118- if (!widget) -- gail/gail.c-147- g_object_unref (obj); gail/gail.c-148- } gail/gail.c-149- } gail/gail.c:150: else if (GTK_CHECK_TYPE ((widget), gnome_canvas)) gail/gail.c-151- { gail/gail.c-152- GObject *focused_item; gail/gail.c-153- So, please remove the canvas dependency again.
Oh sorry. I noticed that in the latest gail tarball that a dependency was needed, so I added it to the tarball moduleset and thought I'd be a good citizen and add it to the svn moduleset for everyone. Oops. :-/ This was just a careless mistake on my part for applying it to svn without double-checking; sorry about that. I've reverted it.
Hi Sven, as you can see in the these code, we don't need to depend on libgnome-canvas. We get the type from a string.
Li: It'd be awesome to get a new atk tarball that doesn't have the libgnomecanvas dependency. ;-)
Sure. I will release 1.19.5 when gnome2.19.5