GNOME Bugzilla – Bug 443851
Wakes up too often
Last modified: 2007-06-05 14:05:35 UTC
From: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242397 ---8<--- evince wakes every 2 seconds up to see if ->modified is set, and if so, it saves the config file. ->modified gets only set in 2 places; and rarely so in practice. The patch attached just arms the timer only when things actually get modified, and the timer then only runs 1 time. ---8<---
Created attachment 89315 [details] [review] evince-timeout.patch Patch from Arjan van de Ven (arjan@linux.intel.com)
Great, thanks a lot, can you please commit it. Also it would be nice to keep it in sync with gedit.
Shall I commit just to trunk, or to gnome-2-18 as well?
As you like
Created attachment 89397 [details] [review] evince-timeout-trunk.patch Patch as committed to trunk
Committed to trunk and gnome-2-18. 2007-06-05 Bastien Nocera <hadess@hadess.net> * shell/ev-metadata-manager.c: (ev_metadata_arm_timeout), (ev_metadata_manager_init), (ev_metadata_manager_shutdown), (ev_metadata_manager_set_last), (ev_metadata_manager_set), (ev_metadata_manager_save): Adapted patch from Arjan van de Ven (arjan@linux.intel.com) to avoid the timeout running all the time, saves on power (Closes: #443851)
Created attachment 89408 [details] [review] evince-simplify-timeout.patch To commit on trunk, a simplified version as pointed out by Paolo Maggi in http://bugzilla.gnome.org/show_bug.cgi?id=444270#c4
Just commit it without questions, thanks a lot.
2007-06-05 Bastien Nocera <hadess@hadess.net> * shell/ev-metadata-manager.c: (ev_metadata_manager_init), (ev_metadata_manager_shutdown), (ev_metadata_manager_set_last), (ev_metadata_manager_set), (ev_metadata_manager_save): Simplify the timeout, no need for modified anymore