After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 443226 - "Delete from disk" doesn't inform user if a failure occurs.
"Delete from disk" doesn't inform user if a failure occurs.
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Browsing
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-02 14:20 UTC by jarlathreidy
Modified: 2007-12-05 11:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
throw-exception-if-delete-fails.patch (984 bytes, patch)
2007-10-31 19:39 UTC, Maxxer
none Details | Review
throw-exception-if-delete-fails.patch (990 bytes, patch)
2007-11-01 07:01 UTC, Maxxer
committed Details | Review

Description jarlathreidy 2007-06-02 14:20:39 UTC
Hi,

I'm running version 0.3.5 on Ubuntu Feisty (7.04). I had deleted quite a few images using F-Spot, as I no longer wanted them. But when I browse with my file manager, I see the images are still there.

After checking the permissions, I see that the images are in fact read-only. If F-Spot had let me know this, I would not have kept deleting for about half an hour.

Fantastic application, great work.

Regards,
Jarlath
Comment 1 Maxxer 2007-10-31 19:39:41 UTC
Created attachment 98267 [details] [review]
throw-exception-if-delete-fails.patch

This patch makes F-Spot throw an exception if the Unlink() fails
Comment 2 Maxxer 2007-11-01 07:01:49 UTC
Created attachment 98297 [details] [review]
throw-exception-if-delete-fails.patch

Correct error reporting.

I'm not sure Sde will like the "return" in MainWindow. Can that cause interruption if thumb deletion occurs?
Comment 3 Stephane Delcroix 2007-12-05 11:12:08 UTC
committed in r3472, without the "return"