After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 443206 - PANGO_SCRIPT_UNKNOWN should not cause a run break
PANGO_SCRIPT_UNKNOWN should not cause a run break
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.17.x
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2007-06-02 13:02 UTC by Martin Hosken
Modified: 2007-06-02 18:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
patch to fix so that PANGO_SCRIPT_UNKNOWN doesn't cause run break (470 bytes, patch)
2007-06-02 13:04 UTC, Martin Hosken
committed Details | Review

Description Martin Hosken 2007-06-02 13:02:14 UTC
Please describe the problem:
PANGO_SCRIPT_UNKNOWN should not cause a run break. Since it is considered a REAL_SCRIPT, it is compares with other scripts as !SAME_SCRIPT.

Fix is to add PANGO_SCRIPT_UNKNOWN to be !REAL_SCRIPT either by modifying #define REAL_SCRIPT (as I have done) or by reordering SCRIPT enum values.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Martin Hosken 2007-06-02 13:04:25 UTC
Created attachment 89233 [details] [review]
patch to fix so that PANGO_SCRIPT_UNKNOWN doesn't cause run break
Comment 2 Behdad Esfahbod 2007-06-02 18:55:08 UTC
Thanks.

2007-06-02  Behdad Esfahbod  <behdad@gnome.org>

        Bug 443206 – PANGO_SCRIPT_UNKNOWN should not cause a run break
        Patch from Martin Hosken

        * pango/pango-script.c: Treat Unknown script like Common and other
        non-"real" scripts.