After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 443166 - nl and es file-roller.xml help files don't validate
nl and es file-roller.xml help files don't validate
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: docs
2.16.x
Other All
: Normal minor
: ---
Assigned To: Maintainers of Gnome user documentation
Maintainers of Gnome user documentation
Depends on:
Blocks:
 
 
Reported: 2007-06-02 09:28 UTC by Hans de Graaff
Modified: 2007-07-11 09:07 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
es/file-roller.xml patch (1.38 KB, patch)
2007-06-02 09:28 UTC, Hans de Graaff
none Details | Review
nl/file-roller.xml patch (1.43 KB, patch)
2007-06-02 09:29 UTC, Hans de Graaff
none Details | Review
Patch against SVN HEAD (7.77 KB, patch)
2007-06-16 07:58 UTC, Hans de Graaff
accepted-commit_now Details | Review

Description Hans de Graaff 2007-06-02 09:28:06 UTC
Documentation 
Section: 
Both the nl and es help files in file-roller don't validate, as can be checked with 'make check'. Both are caused by simple markup problems. I'll include patches for both

Correct version:


Other information:
Comment 1 Hans de Graaff 2007-06-02 09:28:43 UTC
Created attachment 89226 [details] [review]
es/file-roller.xml patch
Comment 2 Hans de Graaff 2007-06-02 09:29:03 UTC
Created attachment 89227 [details] [review]
nl/file-roller.xml patch
Comment 3 Paolo Bacchilega 2007-06-04 15:20:12 UTC
Looks like these patches are obsolete now, with the current documentation system the only xml file is in help/C, while the language subfolders contain only the .po file.
Comment 4 Hans de Graaff 2007-06-06 15:38:55 UTC
Indeed that does seem to be the case. I guess these patches are only useful if there will be another 2.16.x release.
Comment 5 Hans de Graaff 2007-06-12 18:10:38 UTC
I just noticed that these problems are also still present in file-roller 2.18.2, so if there is another 2.18.x release these patches may still be useful.

I've also checked svn. These problems are still present there with some new ones added. 'make check' is your friend. Since I'm not familiar with the new build process I've not updated the patch.
Comment 6 Hans de Graaff 2007-06-16 07:58:38 UTC
Created attachment 90047 [details] [review]
Patch against SVN HEAD

The attached patch fixes all validation errors in the documents, including the ones reported earlier in this bug and some new ones.
Comment 7 Paolo Bacchilega 2007-07-11 09:07:41 UTC
patch applied to SVN, thanks.