After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 442866 - Static colors for treeview expanders
Static colors for treeview expanders
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
0.11.x
Other Linux
: Normal major
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 495488 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-06-01 10:56 UTC by Andrea Cimitan
Modified: 2008-09-30 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (567.52 KB, image/png)
2007-06-01 11:05 UTC, Andrea Cimitan
  Details
first stab at fixing this (9.44 KB, patch)
2007-12-20 14:36 UTC, Jonathan Matthew
none Details | Review

Description Andrea Cimitan 2007-06-01 10:56:16 UTC
With rhythmbox 0.11 you introduced a new treeview on the left sidebar, with expandable proprieties.
The problem is that those expanders has a fixed "gray" color so the text inside them becomes unreadable

Steps to reproduce:
1. Open theme manager and select a dark theme
2. open rhythmbox and see the sidebar
Comment 1 Andrea Cimitan 2007-06-01 11:05:14 UTC
Created attachment 89174 [details]
Screenshot

this is a screenshot
Comment 2 Andrea Cimitan 2007-06-24 10:56:43 UTC
Is this fixed in HEAD?
Comment 3 The Lemon Man 2007-06-29 14:44:26 UTC
i have tested with a theme like your and i can read the text. For me this isn't a bug because if you use it with a light theme you can read all

Comment 4 Andrea Cimitan 2007-06-29 14:51:05 UTC
@Giuseppe:
it represent a bug because the UI has to be intependent from the kind of theme the user chose. It should be working with every theme as the user shouldn't have to change is theme because of an application.
Comment 5 The Lemon Man 2007-06-29 14:56:05 UTC
@ Andrea

Yes, i know, this is an accessybilty problem. anyone of the rhythmbox team have read this bug? boh
Comment 6 William Jon McCann 2007-06-29 15:44:47 UTC
Yes, this is a bug.  We should probably just drop the background color setting until we can figure out a good theme compliant way.  It actually looks pretty good without a bg color since we also have indentation to indicate hierarchy.
Comment 7 Jonathan Matthew 2007-07-14 07:13:26 UTC
I think it looks OK without a background colour in the group rows, but my initial impression is that a border around those rows would help.
Comment 8 Jonathan Matthew 2007-07-14 07:18:54 UTC
Actually, that's what's being suggested in bug 441891 (maybe that's where I got the idea?).  Perhaps we should close this as a duplicate.
Comment 9 Andrea Cimitan 2007-08-03 00:57:59 UTC
This problem is still present now.
The problem is that gnome-themes-extras will have a dark theme that to witch rhythmbox will be incompatible with.
I suggest to _at least_ shade the base color instead the bg.
But changing the widget would be better.
Notice that the theme will be released with 2.20
Comment 10 Jonathan Matthew 2007-11-10 10:40:04 UTC
*** Bug 495488 has been marked as a duplicate of this bug. ***
Comment 11 Jonathan Matthew 2007-12-20 14:36:39 UTC
Created attachment 101322 [details] [review]
first stab at fixing this

Removes the background from the source group rows, adds separators between source groups.  It doesn't quite look right to me.
Comment 12 Bastien Nocera 2008-09-30 17:48:12 UTC
The patch in bug 553984 has already been committed, and should fix this problem.