After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 442677 - WideBand AMR payloaders
WideBand AMR payloaders
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.5
Other All
: Normal enhancement
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-31 19:48 UTC by Daniel Charles
Modified: 2007-06-01 14:22 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch that includes the files for wb amr payloaders in gst-plugins-good (28.32 KB, patch)
2007-05-31 20:50 UTC, Daniel Charles
committed Details | Review

Description Daniel Charles 2007-05-31 19:48:59 UTC
The RTP plugin does not has the wide-band AMR payloaders (payloader-depayloader) to handle sample rates of 16Khz and bit rates according to ETSI TS 126 201 V6.0.0
Comment 1 Daniel Charles 2007-05-31 20:48:14 UTC
Attached is the patch file that includes the implementation of both payloader and depayloader
Comment 2 Daniel Charles 2007-05-31 20:50:36 UTC
Created attachment 89136 [details] [review]
Patch that includes the files for wb amr payloaders in gst-plugins-good
Comment 3 Wim Taymans 2007-06-01 11:16:19 UTC
I added support for this in the NB (de)payloader since they share all code. Does this also work for you?

        Based on Patch by: Daniel Charles <dcharles at ti dot com>

        * gst/rtp/gstrtpamrdepay.c: (gst_rtp_amr_depay_setcaps),
        (gst_rtp_amr_depay_process):
        * gst/rtp/gstrtpamrdepay.h:
        * gst/rtp/gstrtpamrpay.c: (gst_rtp_amr_pay_base_init),
        (gst_rtp_amr_pay_class_init), (gst_rtp_amr_pay_init),
        (gst_rtp_amr_pay_setcaps), (gst_rtp_amr_pay_handle_buffer):
        * gst/rtp/gstrtpamrpay.h:
        Add support for AMR-WB.
        Small cleanups such as using BOILERPLATE.
Comment 4 Daniel Charles 2007-06-01 14:22:17 UTC
Yes, either way is okay for us as far as it's there.

Thanks,