GNOME Bugzilla – Bug 442528
Improvements to the Simple theme
Last modified: 2018-08-17 19:39:28 UTC
The Simple theme is one of my favourite themes as it is very nice and very fast. But it has a few problems making it unusable for me: 1. The color of text on a progress bar is very similiar to the color of the progress bar itself, so it is barely readable. 2. Checkbuttons and radiobuttons in menus are *not visible* when the particular menu entry is highlighted. I suggest adjusting the gtkrc of the Simple theme in order to resolve these problems and thus achieve much better usability for this great theme. I will attach screenshots proving the two statements above and a diff to gtkrc resolving these issues. Other information:
Created attachment 89088 [details] Text on a progressbar with the Simple theme As you can see the text is barely readable with the Simple theme...
Created attachment 89089 [details] Text on a progressbar with modified Simple theme Much better, don't you think?
Created attachment 89090 [details] Radiobuttons in a menu with the Simple theme Actually you don't see that there are radio buttons, but they are there!
Created attachment 89091 [details] Radiobuttons in a menu with the modified Simple theme With the modified theme, the radiobuttons get visible again.
Now the diff: root@erde:/usr/share/themes# diff Simple/gtk-2.0/gtkrc MySimple/gtk-2.0/gtkrc 24c24 < base[ACTIVE] = "#456b7f" --- > base[ACTIVE] = "#c2c2be" 61,65d60 < style "progressbar" = "default" < { < fg[PRELIGHT] = "#ffffff" < } < 67c62 < class "GtkMenuItem*" style "menu" --- > class "GtkMenuItem*" style "default" 70d64 < class "GtkProgressBar" style "progressbar"
Admittedly I noticed two small "regressions" after adjusting the gtkrc as stated above: 1. Radiobuttons and checkboxes in menus now have a different style than those used in "ordinary" places. This is not nice, but still better than the situation before, when they were not visible at all in menus. Besides, this can be solved by replacing class "GtkCheckButton" style "togglebuttons" class "GtkRadioButton" style "togglebuttons" with class "GtkCheckButton" style "default" class "GtkRadioButton" style "default" in gtkrc. 2. Highlighting of menu entries now looks slightly different, but I don't know how to resolve this and I can live with that very well...
I further modified the gtkrc of the Simple theme in order to get rid of the two regressions mentioned above. Now I think Simple looks and feels *really* great. Attaching a patch. Please someone apply it and give me a feedback what (s)he thinks about it. The patched gtkrc will contain three commented-out lines that allow you to switch between a dark (greenish) and a bright (whiteish) version of the progress bars. Please tell me which one is better.
Created attachment 89940 [details] [review] Patch to gtkrc of the Simple theme
Created attachment 91746 [details] Nautilus radio buttons in Simple theme Hmm... I see your issue with progress bars, but my radio buttons don't look like that at all with the Simple theme, see attached. Can somebody else confirm either way?
The radio button was fixed in a newer redmond version. The progress bar problem happend when thinice was ported to Cairo. It now uses another color to draw the progress bar. Maybe thinice should be changed back instead of fixing the theme.
gnome-themes is not under active development anymore since 2011. As written in https://gitlab.gnome.org/Archive/gnome-themes/commit/4df81cf0a7fd8d3da6591c4c142f47dfd7778d5f , it is obsolete. Its codebase has been archived: https://gitlab.gnome.org/Archive/gnome-themes/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.