GNOME Bugzilla – Bug 441766
Disabling the property API leads to build/linking broblems
Last modified: 2007-06-10 10:42:57 UTC
I tried to disable the property API, but run into linking problems. The connect_property_changed() uses PropertyProxyConnectionNode, but given that the property API is disabled, the propertyproxy_base.h will practically be preprocessed to empty. This will compile just fine, but b0rk upon linking time due to missing symbols. The fix looks obvious (move the ifdefs a bit in propertyproxy_base.cc) and I'll attach a patch for this below.
Created attachment 88929 [details] [review] Move PropertyProxyConnectionNode outside the property API #ifdef
I am surprised that this is necessary, because we do use this API in the maemomm documentation examples. That needs some investigation. If somehow this has never been used, then we can definitely add the return type requested in bug #433984. By the way, for what platform do you need to build gtkmm?
Created attachment 88930 [details] [review] Disable the property API test if the API is not present While I'm at it, here's a fix for the property tests too
(In reply to comment #2) > I am surprised that this is necessary, because we do use this API in the > maemomm documentation examples. That needs some investigation. Yes, seems a bit odd if it worked before. OTOH as far as I can tell the fix really should be needed, as it will end up with missing symbols otherwise... > If somehow this has never been used, then we can definitely add the return type > requested in bug #433984. Indeed. > By the way, for what platform do you need to build gtkmm? I'm building it for a demo bundle on top of the Maemo platform, where we don't want to depend on the repositories and likely do want to use some specific build options.
> I'm building it for a demo bundle on top of the Maemo platform, where we don't want to depend on the repositories So you probably should start with the gtkmm debian files in maemo garage. Hopefully you can provide patches for them if necessary.
Maybe this is OK in gtkmm 2.6, but maybe not in gtkmm 2.10.
This is already OK in glibmm svn trunk for glibmm 2.11/2.12: http://svn.gnome.org/viewcvs/glibmm/trunk/glib/glibmm/propertyproxy_base.cc?view=markup and 2.8: http://svn.gnome.org/viewcvs/glibmm/branches/glibmm-2-8/glib/glibmm/propertyproxy_base.cc?view=markup 2.6 doesn't have it, but I think it doesn't need it: http://svn.gnome.org/viewcvs/glibmm/branches/glibmm-2-6/glib/glibmm/propertyproxy_base.cc?view=markup I have fixed it for 2.10 too now. I have also applied the tests patch to gtkmm svn trunk and gtkmm 2.10. Thanks. Please remember to patch the ChangeLog in future.