GNOME Bugzilla – Bug 441419
"go" button's behaviour
Last modified: 2007-06-05 20:47:25 UTC
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/epiphany-browser/+bug/116814 "Binary package hint: epiphany-browser The "go" button acts as soon as the mouse button -be it the left or middle button- is pressed over it. This behaviour is different to other buttons' behaviours, which adopt a "pressed" appearance when the mouse button is pressed, and act when it is released. Merely an aesthetic issue, but there it is. ... I'm using Gutsy. The "go" button has been recently patched to accept middle-clicks, that might be related to this bug."
problem is caused by the patch for this bug: http://bugzilla.gnome.org/show_bug.cgi?id=362591 The patch connected the GO button to the button-pressed-event, I think it should be connected to the button-released-event.
Created attachment 88960 [details] [review] Solution for bug 441419. The only difference is the event type that is changed from "button-press-event" to "button-release-event". This solves this little inconsistency.
Somehow the patch seems to be inverted? Anyway applied with -R it's the right thing, thanks for the patch!
Thanks Sebastiaan!, committed to trunk as revision 7072. Should this go to 2.18 too? 2007-06-05 Diego Escalante Urrelo <diegoe@gnome.org> * src/ephy-go-action.c: Fix go button behaviour to react to button-release-event and not button-press-event. Patch by Sebastiaan Samyn. Bug #441419.
Committed to 2.18.