After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 441393 - dshowwrapper is not autotooled
dshowwrapper is not autotooled
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-26 11:31 UTC by Ali Sabil
Modified: 2011-08-16 09:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Proposed patch that autotools dshow (12.83 KB, patch)
2007-05-26 11:33 UTC, Ali Sabil
needs-work Details | Review

Description Ali Sabil 2007-05-26 11:31:53 UTC
Please describe the problem:
The current CVS head doesn't include dshowwrapper in its autofoo, which makes it impossible to build using the autotools (+mingw32).

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Ali Sabil 2007-05-26 11:33:57 UTC
Created attachment 88841 [details] [review]
Proposed patch that autotools dshow

The patch is still unfinished, actually it autotool dshowwrapper, and fix the compilation errors with mingw32, but it doesn't seem to build dll files for dshow, only .a are built.
Comment 2 Tim-Philipp Müller 2007-05-26 11:56:39 UTC
Thanks for the patch; it does look like it needs a bit more work though, for example:

 - fix the FIXME in the directshow configure.ac check? Is there actually
   a point to the AC_LINK_IFELSE there? (Does it test more than the
   presence of those headers?

 - the different headers thing needs to be sorted out somehow, ie. either
   you check for both variants or pass magic cppflags so MingW checks for
   headers in a case-insensitive way (surely that exists?)
   (DShow.h vs. dshow.h and Rpc.h vs. rpc.h)

 - would be nice if it didn't include cosmetic changes for
   single files that are otherwise not modified

 - not include iirequalizer modifications

 - regarding gstdshowinterface.h: does MingW have 'bool'? if yes, would
   that be equivalent?

 - sys/dshowsrcwrapper/Makefile.am: what about the header files?
   Did you make sure 'make distcheck' passes?
Comment 3 Ali Sabil 2007-05-26 12:41:53 UTC
- Concerning the AC_LINK_IFELSE, It would be nice to initialize COM, and create a CaptureGraphBuilder2, to check for DirectShow

- Concerning the case sensitivity, it seems like mingw have all the headers they distribute as lowercase, but then, when you use an external SDK, many files are in mixed case... This needs to be investigated more

- Sorry about that, it just remove some warnings about files not ending with an empty line :)

- ok

- bool is a c++ keyword, but it seems like BOOL is defined, not sure if it is equivalent or not

- oups, seems like I forgot to add them :D

p.s. this is to be considered an unfinished patch, because even with the current patch it doesn't build the required .dll files
Comment 4 Tobias Mueller 2009-02-08 17:07:29 UTC
As the questions in comment #1 seem to be answered, I am reopening.
Comment 5 Sebastian Dröge (slomo) 2011-05-18 13:20:34 UTC
Well, all questions were answered but the patch needs some more work before it can be accepted. Are you going to work on this Ali or is this still a problem at all?
Comment 6 Akhil Laddha 2011-07-01 05:07:46 UTC
Ali, can you please respond to comment#5 other wise bug will be closed after waiting for certain time period ?
Comment 7 Akhil Laddha 2011-08-16 09:12:05 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!