After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 441118 - Incorrect caps in G.711 RTP depayloaders
Incorrect caps in G.711 RTP depayloaders
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.4
Other All
: High normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-25 07:18 UTC by Tommi Myöhänen
Modified: 2007-06-11 10:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch that adds missing "rate" fields to depayloader's output caps (1.01 KB, patch)
2007-05-25 07:19 UTC, Tommi Myöhänen 		committed Details | Review

Description Tommi Myöhänen 2007-05-25 07:18:14 UTC 
Please describe the problem:
Since G.711 (a-law & u-law) do not use fixed samplerate, it is necessary to pass the rate information in the caps structure. Current implementation of gstrtppcm(a/u)depay.c define output caps as follows:

"audio/x-(a/u)law, " "channels = (int) 1"

Even this "rate" field is omitted, the pipeline works. However, it causes the caps renegotiation to happen with every buffer that is passed from depayloader to decoder. This is quite a performance drawback.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Tommi Myöhänen 2007-05-25 07:19:03 UTC 
Created attachment 88783 [details] [review]
A patch that adds missing "rate" fields to depayloader's output caps
Comment 2 Wim Taymans 2007-06-11 10:24:16 UTC 
        Patch by: Tommi Myöhänen  <ext-tommi dot myohanen at nokia dot com>

        * gst/rtp/gstrtppcmadepay.c: (gst_rtp_pcma_depay_setcaps):
        * gst/rtp/gstrtppcmudepay.c: (gst_rtp_pcmu_depay_setcaps):
        Add missing rate fields to caps. Fixes #441118.