GNOME Bugzilla – Bug 441060
Sidebar context switching
Last modified: 2008-06-02 09:03:35 UTC
I began to implement the sidebar context switching: http://www.f-spot.org/New_Features_-_Sidebar Stephane mentioned that I should post my work to bugzilla, so here is it. It is not yet perfect, but next week I have no time to work on it (vacation) and maybe someone is interested to look on it. At the Moment it looks like: http://www.flickr.com/photos/8124695@N06/512379761/ http://www.flickr.com/photos/8124695@N06/512342648/ http://www.flickr.com/photos/8124695@N06/512342606/ something that have to be implemented (IMHO) Exif: - don't update extended metadata, if the expander is closed (it takes some time and make a little delay while changing selection) - expander should be handled better, so a Expander was opened before changing the selection is opened after. Information: - Tags should be drag'n'dropable - Tags should be removeable from the current photo here (popup menu) - Exported locations should be removeable (if a photo was exported to a folder and the folder was moved the link doesn't work anymore) - the Exposure string should be every time consists of 2 lines (at the moment it doesn't if no ISO Speed wasn't found, but FNumber and Exposure time was found) - Exported locations is not (automatically) updated after export. Hope for some comments. Mike
Created attachment 88778 [details] [review] Sidebar Patch And here is the patch. And something else I forgot. The MetadataDisplay (MetadataDisplay.cs) is (at the moment) another class than InfoDisplay, because InfoDisplay is still used by f-spot --view.
Hey Mike, the 3 new files (Sidebar, Metadatadisplay and MenuButton) are missing in your patch. the easiest way to have them included in a svn diff is to 'svn add' them, then re-do your 'svn diff' regards s
Created attachment 88785 [details] [review] Sidebar Patch here is it, thx.
F-Spot crashes with this patch, when unavailable picture is clicked. Log: http://pastebin.ca/514325
I found the Problem, I'll fix it next week. thx.
Created attachment 89336 [details] [review] Sidebar Patch Here is a new one. Changes: * added some changes from Stephane ** support for icons in button and menu ** throw an event when the close button is clicked (widgets should compile without MainWindow...) ** move Sidebar in Widgets (folder and namespace) ** other things... * It works now with unavailable pictures (Comment #4) * better handling with opened expanders in MetadataDisplay.cs
Created attachment 89423 [details] [review] Sidebar Patch And an new one again: * created a new class InfoVBox which is used by InfoBox and in FullScreenView (to display name, version, date, ... ) * MetadataDisplay now uses a Delay (like InfoBox), too * MetadataDisplay and InfoBox now uses own Handler for Selection.Changed and Selesction.ItemsChanged events * some little changes
Any chance to have some screenshots on picasa or somewhere?
There were some behavivour changes, but only a few are visible. but here are some (new MenuButton with icons form Stephane, filesize when more than one photo is selected): http://www.flickr.com/photos/8124695@N06/532809464/ http://www.flickr.com/photos/8124695@N06/532809512/ http://www.flickr.com/photos/8124695@N06/532905265/ http://www.flickr.com/photos/8124695@N06/532809742/
Looks great :) I like it....
Created attachment 89497 [details] [review] Sidebar Patch again some little fixes (nothing visible)
Adding custom-written module support would be great..
Created attachment 91948 [details] [review] Sidebar Patch here is a new Version, after a long time..... * restore last shown entry at restart * adding the sidebar to f-spot --view * build on rev 3222 @Sergey Nazarov: I think so, it shoul be possible to ddo it with the Addins.
Mike, I just tried this patch. It is really great and opens up for a lot of opportunities. However, I got this warning when running f-spot: (f-spot:15738): Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Error on line 2 char 18: Element 'markup' was closed, but the currently open element is 'small' It happens when I select a photo.
Created attachment 91980 [details] [review] Sidebar Patch some little changes
I tried the newest patch. Could not get it to compile: make[2]: *** No rule to make target `Widgets/MenuButton.cs', needed by `f-spot.exe'. Stop.
Christoffer, be creative ! take MenuButton.cs from the previous patch set...
Latest patch seems fine. I would suggest to change the naming in the Exif page. "Image Directory" etc. does not sound natural to me. Maybe "Image Data"?
Created attachment 92536 [details] [review] Sidebar Patch and a new one, with some fixes and hopefully with all files included :D (build on r3252) Christoffer: the thing with "Image Directory" have to be changed in Exif.cs. But "directory" is imho the correct spelling and it was used in earlier versions in the MetadataBrowser(dialog). Mike
very nice! working fine here!
Two bad sides: 1. The info window it takes a lot of time for loading! 2. This patch made completely disappear all the export functions under File > Export to... These warnings weren't appearing before applying the patch, I don't know if it matters. (f-spot:6726): Gtk-CRITICAL **: gtk_tooltips_set_tip: assertion `GTK_IS_TOOLTIPS (tooltips)' failed (f-spot:19809): Gtk-WARNING **: gtk_menu_attach_to_widget(): menu already attached to GtkMenuItem Checked right now with latest SVN.
Maxxer: are you running it --uninstalled or something ? that usually prevent extensions from loading, so no 'Export to' menu...
(In reply to comment #22) > Maxxer: are you running it --uninstalled or something ? that usually prevent > extensions from loading, so no 'Export to' menu... no. btw compiling it without the patch make the export functions come back again, I tried it! The Export to menu exists, but it's not populated!
Created attachment 92590 [details] [review] Sidebar Patch Maxxer: thx for testing. 1) what do you mean? when it takes a lot of time? startup? switching photos? switching the sidebar? 2) done with the new patch..... The warnings you get. I can't reproduce it. Maybe it is done with the new patch.
(In reply to comment #24) > 1) what do you mean? when it takes a lot of time? startup? switching photos? > switching the sidebar? when clicking on a picture the first time, with some tags and some exports, it takes a bit of time for loading. but I tried right now and it doesn't seems so slow, maybe it was just a feeling. > 2) done with the new patch..... Works! Great!
Patch still is great, but now I have no Export menu items. I am using revision 3257 to patch against and installed in ~/unstable/f-spot I get these warnings: (f-spot:27375): Gtk-CRITICAL **: gtk_tooltips_set_tip: assertion `GTK_IS_TOOLTIPS (tooltips)' failed but I am not sure if it is because of this patch. Would it make sense to have direct keyboard navigation for the items in the drop-down (Tags, Exif, Information)? Right now, you have to tab-navigate and then select an item.
(In reply to comment #26) > Patch still is great, but now I have no Export menu items. > sorry, I've tried it again, but no problems with the export menu. > I am using revision 3257 to patch against and installed in ~/unstable/f-spot > > I get these warnings: > > (f-spot:27375): Gtk-CRITICAL **: gtk_tooltips_set_tip: assertion > `GTK_IS_TOOLTIPS (tooltips)' failed I have some of such warnings too, but even without the patch. > Would it make sense to have direct keyboard navigation for the items in the > drop-down (Tags, Exif, Information)? > > Right now, you have to tab-navigate and then select an item. > I thought about using the mouse-scrollrad to change the sidebar.
Christoffer: to your mockup: http://www.flickr.com/photos/10057430@N03/927913202/ I would prefer the edit-functions in sidebar too.
Mike, Having the edit-functions in the sidebar would be great. Also, having Adjust Color with the Histogram would also fit nicely there. However, this would require some sort of preview function, so it is probably best that is separately handled in another bug :-)
Hi, I'm new user of bugzilla and patch stuff ... So my question may seem ridiculous: I've tried to apply the patch to a the most recent svn version of f-spot and I've got this Makefile.am.rej *************** *** 154,159 **** $(srcdir)/MainWindow.cs \ $(srcdir)/MetaStore.cs \ $(srcdir)/MetadataStore.cs \ $(srcdir)/OpenWithMenu.cs \ $(srcdir)/Operation.cs \ $(srcdir)/PhotoImageView.cs \ --- 155,161 ---- $(srcdir)/MainWindow.cs \ $(srcdir)/MetaStore.cs \ $(srcdir)/MetadataStore.cs \ + $(srcdir)/MetadataDisplay.cs \ $(srcdir)/OpenWithMenu.cs \ $(srcdir)/Operation.cs \ $(srcdir)/PhotoImageView.cs \ As I understand, it can't modify the Makefile.am file as it is different from what it is waiting for to be. I try to add manually the + but the result is still bad: I do not have the sidebar_patch installed ... Thank for your help and indulgence. R
What about this (and bug #398124)? Hasn't this second bug more features?
Merge coming up.
Patch merged, further improvements coming up. Thanks for writing this!