After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 440859 - enable file chooser previews for epiphany
enable file chooser previews for epiphany
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
: 503903 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-05-24 02:10 UTC by Jean-François Fortin Tam
Modified: 2007-12-17 14:02 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Implements file previews (1.87 KB, patch)
2007-09-27 00:01 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review

Description Jean-François Fortin Tam 2007-05-24 02:10:19 UTC
Hello, I came from bug #372344.

I would really like Epiphany to enable the GTK filechooser's preview (at least for images). I'm not sure if it could be of use for Save, but it would be vital for "open" or "browse" choosers.

Here is a use case: Bob wants to send a picture by attaching it to a message in Gmail/Hotmail/etc, or he wants to upload that picture to picasa/flickr manually. Or he wants to post cats on 4chan because it's caturday desu.

The problem is, all his files are named 3029239423.jpg, PICT0012.JPG, PICT0013.JPG, etc. And he has thousands of them.

He would have to browse the folder containing the files using Nautilus, memorize their location and file name, and then select them with epiphany's file chooser. Not intuitive.

What do you think? I'm no programmer, but I would guess that the gtk file chooser would only need an extra argument to enable that preview like in GIMP? Having this feature would allow me to remain sane for a couple of months more (until I manage to convince the gtk guys that an icon view is not evil :) and it would make epiphany a LOT more integrated into the GNOME desktop.

Looking at http://pygtk.org/pygtk2reference/class-gtkfilechooser.html (yeah I know, that's the python gtk bindings and Epiphany is not in python), I would *guess* that the relevant function(s) could be

set_preview_widget(preview_widget)
set_preview_widget_active(active)

Let me know what you think!
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2007-05-24 04:52:02 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 144337 ***
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2007-05-24 04:53:34 UTC
Oops, that's about HTML. Reopening.
Comment 3 Reinout van Schouwen 2007-05-24 12:37:01 UTC
Note that it's possible to drag and drop a random object from Nautilus to the GTK file chooser and it will show the correct path. But I agree this could be a useful feature.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2007-05-24 15:32:01 UTC
I suspect this is a mozilla thing, I couldn't find the dialog on ephy's source (well there's a dialog but it's for File>Open).
And it also looks like the FF one so I would say it's mozilla's fault. Am I right (hope not)?
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2007-09-27 00:01:36 UTC
Created attachment 96267 [details] [review]
Implements file previews

This creates previews for images in the file chooser, I don't think there are other filetypes worth previewing.
Comment 6 Christian Persch 2007-09-27 12:19:56 UTC
(In reply to comment #5)
> This creates previews for images in the file chooser, I don't think there are
> other filetypes worth previewing.

Well, since it's a web browser, HTML documents could use previews too. Let's tackle that later though, it's going to be a tad more complicated :)

+	gchar *filename;

Just char, not gchar.

+		pixbuf = gdk_pixbuf_new_from_file_at_size (filename, 100, 100, NULL);

Is 100 a good size? it seems a bit small... Also let's #define this number at least.

Otherwise this patch looks fine, thanks!
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2007-09-28 05:02:11 UTC
------------------------------------------------------------------------
r7502 | diegoe | 2007-09-27 23:59:47 -0500 (Thu, 27 Sep 2007) | 6 lines

* lib/ephy-file-chooser.c:

        Add a preview for the FileChooser. The default size is 150x150.
        Fixes bug #440859.


Do you think we should add the HTML previewing? I don't know if it has enough use cases.
Comment 8 Christian Persch 2007-09-28 13:21:07 UTC
(In reply to comment #7)
> Do you think we should add the HTML previewing? I don't know if it has enough
> use cases.

Let's wait and see if someone requests it with a good reason :) 

Comment 9 Reinout van Schouwen 2007-09-28 13:53:37 UTC
If we're going to show previews we might as well re-use the nautilus thumbnailer to fetch previews for anything anyone might want to upload to a website.

Comment 10 Cosimo Cecchi 2007-12-17 00:02:05 UTC
*** Bug 503903 has been marked as a duplicate of this bug. ***