After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 440203 - Support multiple RTSP headers of the same type
Support multiple RTSP headers of the same type
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-21 15:22 UTC by Peter Kjellerstedt
Modified: 2007-05-24 08:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Support multiple RTSP headers of the same type (19.02 KB, patch)
2007-05-21 15:23 UTC, Peter Kjellerstedt
committed Details | Review

Description Peter Kjellerstedt 2007-05-21 15:22:01 UTC
Please describe the problem:
The attached patch changes RTSPMessage to store the parsed headers in a GArray instead of a GHashTable, thereby allowing multiple headers of the same type. It also changes rtsp_connection_send() to only add Session and Authorization headers to requests.

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
The change in gst_rtspsrc_parse_methods() to support multiple Allow/Public headers is totally untested, but I hope I got it right...
Comment 1 Peter Kjellerstedt 2007-05-21 15:23:44 UTC
Created attachment 88552 [details] [review]
Support multiple RTSP headers of the same type
Comment 2 Wim Taymans 2007-05-24 08:11:16 UTC
        Patch by: Peter Kjellerstedt  <pkj at axis com>

        * gst/rtsp/gstrtspsrc.c: (gst_rtspsrc_setup_auth),
        (gst_rtspsrc_try_send), (gst_rtspsrc_parse_methods),
        (gst_rtspsrc_setup_streams), (gst_rtspsrc_open),
        (gst_rtspsrc_play):
        (rtsp_connection_send), (rtsp_connection_receive):
        * gst/rtsp/rtspextwms.c: (rtsp_ext_wms_after_send):
        Fix for new API.

        * gst/rtsp/rtspconnection.c: (add_auth_header),
        Only add authorisation and session headers when sending messages.

        * gst/rtsp/rtspmessage.c: (key_value_foreach), (rtsp_message_init),
        (rtsp_message_init_request), (rtsp_message_init_response),
        (rtsp_message_unset), (rtsp_message_add_header),
        (rtsp_message_remove_header), (rtsp_message_get_header),
        (rtsp_message_append_headers), (dump_key_value),
        (rtsp_message_dump):
        * gst/rtsp/rtspmessage.h:
        Add support for multiple headers of the same type by storing the parsed
        headers in a GArray instaed of a hashtable.