GNOME Bugzilla – Bug 440184
Gnome clock applet does not display multi-days event from evolution correctly
Last modified: 2007-05-21 21:17:02 UTC
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/gnome-panel/+bug/114515 "A small regression from Edgy to Feisty : the clock calendar pop-up shows multi-days event defined in evolution as one day event (only the first day in bold) even if the bottom panel of the calendar correctly shows the event for all consequent days). http://librarian.launchpad.net/7619609/cal.png cal.png"
Created attachment 88549 [details] [review] fix the bug The bug has been introduced with http://svn.gnome.org/viewcvs/gnome-panel?view=revision&revision=10180. The new patch makes it make all the days untill the duration is reached (which is n* 86400). I've tested the change with one all day event, one multi-days event, one normal event on on e day and another spawing on an another days, they are all displayed correctly
Doesn't this patch reintroduce bug 305022? The code you propose does the same thing as the code before the fix for bug 305022.
Not, it's not, supposing the other bug happens in the case when the event doesn't spaw on the day. Take the example of a duration = 100 000 = 1.16 days, 2 days have to be marked on the calendar) duration / 86400 = 1 (that's an int division), * code before 305022 day_offset < 1 is not true so there is no extra day marked, which was the bug * code now day_offset <= 1, one extra day is marked * the patched version day_offset <= 1 100 000 != 86400 * 1 one extra day is marked The thing is that the duration / 86400 = 1 when 86400 <= duration < 172799, but we don't want to add a day when it's = 86400 (which is exactly one day), that's the case the suggest patch is changing
Created attachment 88565 [details] [review] updated version according to Vincent comment I've commited this version