GNOME Bugzilla – Bug 43975
View as Java Archive (jar)
Last modified: 2006-12-16 10:27:49 UTC
(this could be based upon the gnome vfs zip viewer). In CodeWarrior on the Mac, there is a fantasic viewer for .jar files. (they are basically .zip files). It is a perfectly normal viewer, except that it allows editing on the contents (i.e. files can be deleted and added), and (this is the good bit) if any .java or .jar file is dropped on the window, it (.java) or its contents (.jar) are placed in the .jar, in the _right place_. Example: Create an empty .jar. Drop onto it a Java files specifiying a package of com.eazel.java. The directorie structure com/eazel/java will be created and the file added. Drop onto it a Java Archive, the directory structure will be copied across and conflicts resolved. Very nice for Java developers. If in doubt find a Mac Java coder using CodeWarrior. ------- Additional Comments From sullivan@eazel.com 2000-10-24 09:56:49 ---- Sounds like a great idea, but obviously too late for version 1.0. ------- Additional Comments From don@eazel.com 2000-12-18 19:38:31 ---- Yep, good idea. Let's do this later ... ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 20:46 -------
*** Bug 48435 has been marked as a duplicate of this bug. ***
sounds like this should almost go into something like file-roller, no?
Hi Glynn, poking me about ancient bugs :) In hindsight this should really be an extension to file-roller, or a nautilus script, or something. I'd hate this to be in Nautilus itself.
what think thee paolo?
Created attachment 28003 [details] [review] This is a unified patch for the enhancement The patch includes code for a new FRCommandJar Object. It adds two new files => fr-command-jar.c and fr-command-jar.h This FRCommandJar Object extends FRCommandZip Object. Hope this completely solves the enhancement.
Paolo, I'm waiting for your comments!!
zip_add is useless, you can simply overwrite add and then call the zip implementation of it in the fr_command_jar_add function, that is FR_COMMAND_ZIP_GET_CLASS(comm)->add instead of FR_COMMAND_ZIP_GET_CLASS(comm)->zip_add
'add' is not a member of the FRCommandZipClass and hence FR_COMMAND_ZIP_GET_CLASS(comm)->add does not work. Also FR_COMMAND_GET_CLASS(comm)->add will not work because it is now pointing to 'fr_command_jar_add' function - a member of FRCommandJarClass. I don't think it is possible to remove zip_add. I'm coming up with a more organised code soon.
Created attachment 30355 [details] [review] This is a unified patch for the enhancement. This new patch, adds four new files. The java specific functions have been moved into 'java-utils.h' and 'java-utils.c'. The code is more organised compared to the previous patch. But the functionality is the same. Paolo, please let me know about any changes u want me to make in the code.
patch applied to CVS (with some changes)
closing the bug...