After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 438940 - [rtph263ppay] Support for Segment Fragmentation based on the GOB Headers
[rtph263ppay] Support for Segment Fragmentation based on the GOB Headers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-16 16:58 UTC by Antoine Tremblay
Modified: 2007-05-21 08:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to implement GOB headers segmentation mecasim (6.46 KB, patch)
2007-05-16 16:59 UTC, Antoine Tremblay
committed Details | Review

Description Antoine Tremblay 2007-05-16 16:58:34 UTC
Where's a patch to add another fragmentation mecasim :

Added Property fragmentation-mode  as defined below  :

  /* This algorithm assumes the H263+ encoder sends complete frames in each
   * buffer */
  /* With Fragmentation Mode at 0 :
   * This algorithm implements the Follow-on packets method for packetization.
   * This assumes low packet loss network. 
   * WIth Fragmentation Mode at 1 :
   * This algorithm separates large frames at synchronisation points (Segments) (See RFC 2429

This must be used in conjuction with ffenc_h263 with the rtp-payload-size > 0
For the encoder to generate non empty GOB Headers

Patch is based on CVS from 16 May 2007

If you decide to allow to patch plz let me commit... :)

If you guys know a way to make the read by byte to find the next gob more efficient it would be nice.. that's the one thing I feel uneasy about... 

I could read 4 bytes at a time but didn't have time to implement this .. and not sure that in this case it would really be more efficient
Comment 1 Antoine Tremblay 2007-05-16 16:59:16 UTC
Created attachment 88301 [details] [review]
Patch to implement GOB headers segmentation mecasim
Comment 2 Wim Taymans 2007-05-21 08:58:04 UTC
Commited with some changes like making the property an enum and removing // comments.


        Patch by: Antoine Tremblay <hexa00 at gmail dot com>

        * gst/rtp/gstrtph263ppay.c: (gst_fragmentation_mode_get_type),
        (gst_rtp_h263p_pay_class_init), (gst_rtp_h263p_pay_init),
        (gst_rtp_h263p_pay_set_property), (gst_rtp_h263p_pay_get_property),
        (gst_rtp_h263p_pay_flush):
        * gst/rtp/gstrtph263ppay.h:
        Add new fragmentation mode based on GOB headers. Fixes #438940.