After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 438727 - Hide implementation details from public headers
Hide implementation details from public headers
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
1.12.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-05-15 21:12 UTC by Ross Burton
Modified: 2013-09-14 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The patch (3.97 KB, patch)
2007-05-15 21:12 UTC, Ross Burton
committed Details | Review

Description Ross Burton 2007-05-15 21:12:05 UTC
Attaching a patch that is required if the DBus port is to ever merge: don't expose the use of Bonobo in the public API of libecal.

There are two parts:

* Move e_cal_view_new() from e-cal-view.h to e-cal-view-private.h
* Don't install headers which are purely implementation details, such as the listeners or ORBit skeletons
Comment 1 Ross Burton 2007-05-15 21:12:37 UTC
Created attachment 88250 [details] [review]
The patch
Comment 2 Srinivasa Ragavan 2007-05-19 21:00:26 UTC
Ross, I would think seriously on API breakage. Can we have some sort of deprecation done here? Are there any users of this API? I seriously dont want to break API. 

I would prefer to float a mail in e-h list on this issue and inform/raise the API breakage if we decide to do that. If possible CC the known consumers of libecal librar. I know Dates uses this which may not be of issue here. But others like zimbra-client evolution-brutus(?) etc needs to be informed IMHO.
Comment 3 Ross Burton 2007-05-20 10:23:01 UTC
There is no API breakage here:

e_cal_view_new() is removed from the public API but it's only used by e-cal.c (and cannot be used by anything else).

The listeners are removed from installation, because nothing can use those either: they are also only used by e-cal.c

That said, I'll raise this on e-h to ensure that nobody is using the APIs (although I fail to see how they could).  A similar patch has been in the addressbook component since 2007-05-15.
Comment 4 Ross Burton 2007-05-22 07:44:10 UTC
Committed to trunk.