GNOME Bugzilla – Bug 438727
Hide implementation details from public headers
Last modified: 2013-09-14 16:50:10 UTC
Attaching a patch that is required if the DBus port is to ever merge: don't expose the use of Bonobo in the public API of libecal. There are two parts: * Move e_cal_view_new() from e-cal-view.h to e-cal-view-private.h * Don't install headers which are purely implementation details, such as the listeners or ORBit skeletons
Created attachment 88250 [details] [review] The patch
Ross, I would think seriously on API breakage. Can we have some sort of deprecation done here? Are there any users of this API? I seriously dont want to break API. I would prefer to float a mail in e-h list on this issue and inform/raise the API breakage if we decide to do that. If possible CC the known consumers of libecal librar. I know Dates uses this which may not be of issue here. But others like zimbra-client evolution-brutus(?) etc needs to be informed IMHO.
There is no API breakage here: e_cal_view_new() is removed from the public API but it's only used by e-cal.c (and cannot be used by anything else). The listeners are removed from installation, because nothing can use those either: they are also only used by e-cal.c That said, I'll raise this on e-h to ensure that nobody is using the APIs (although I fail to see how they could). A similar patch has been in the addressbook component since 2007-05-15.
Committed to trunk.