After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 438178 - only merge translations for languages in LINGUAS
only merge translations for languages in LINGUAS
Status: RESOLVED FIXED
Product: intltool
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: intltool maintainers
intltool maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-13 19:52 UTC by Christian Persch
Modified: 2007-08-27 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.30 KB, patch)
2007-05-13 19:55 UTC, Christian Persch 		accepted-commit_now Details | Review

Description Christian Persch 2007-05-13 19:52:49 UTC 
(Not exactly the same as bug 309566, although mentioned in comment 25 there; so I'm opening a new bug.)

Currently, intltool-merge merges strings from _all languages which have a po file in the given po dir_ into the target files, even for those po files whose language is omitted from LINGUAS (either po/LINGUAS or $LINGUAS env var).

This is bad, e.g. when you're building a package that has many translations, but you only need some (e.g. when building a maemo deb from a GNOME package, the schemas and desktop files will be bloated by string from languages that you're _never_ going to see on the target device).
Comment 1 Christian Persch 2007-05-13 19:55:01 UTC 
Created attachment 88128 [details] [review]
proposed patch

This patch makes intltool respect $LINGUAS and po/LINGUAS when merging translations. (I'm not a perl expert, so it can probably be improved massively.)
Comment 2 Rodney Dawes 2007-08-26 19:35:47 UTC 
Please commit this.
Comment 3 Christian Persch 2007-08-27 19:58:41 UTC 
        * intltool-merge.in.in: Only merge translations for languages listed
        in LINGUAS. Bug #438178.