After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 437938 - In mini mode, clicking the close button on the window quits the program
In mini mode, clicking the close button on the window quits the program
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Other Extensions
git master
Other Linux
: Normal trivial
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 589018 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-05-12 16:48 UTC by Derwin McGeary
Modified: 2009-07-19 19:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Modifies Minimode to use NotificationArea plugin if active. (1.27 KB, patch)
2007-08-26 13:00 UTC, Craig Nellist 		none Details | Review
Updated to the trunk (1.40 KB, patch)
2009-02-17 02:37 UTC, Alexander Kojevnikov 		none Details | Review

Description Derwin McGeary 2007-05-12 16:48:05 UTC 
This behaviour is inconsistent:

Open Banshee
Load Notification Area Icon plug in (Edit->Plug-ins)
Play a song, click the close window button.
Song continues to play, but Banshee is only displayed as notification area icon
Click notification area icon to view the window again
Load mini mode plugin (Edit->plug-ins)
Set View->Mini mode
Click the close window button.
Banshee quits!

This surprised me when it happened because I am not used to mini mode, and it seems to me that Banshee should not behave differently in those two cases.

This is on Ubuntu 7.04.  Thank you.
Comment 1 Nuno Santos 2007-06-29 23:05:06 UTC 
I can confirm this behaviour, and I also agree, it shouldn't exit when closing the window while in mini mode.
Comment 2 Craig Nellist 2007-08-26 13:00:18 UTC 
Created attachment 94361 [details] [review]
Modifies Minimode to use NotificationArea plugin if active.
Comment 3 Josiah Ritchie - flickerfly 2007-08-26 18:12:49 UTC 
Thanks for the patch on this inconsistency.
Comment 4 Bertrand Lorentz 2008-08-15 19:15:38 UTC 
This issue is still present in SVN trunk, but the patch doesn't apply anymore.
Comment 5 Alexander Kojevnikov 2009-02-17 02:37:58 UTC 
Created attachment 128878 [details] [review]
Updated to the trunk

This is my first patch for Banshee, please let me know if it doesn't look good.

The patch was updated to compile when applied to the trunk. I also added a call to `base.Hide ();` to the delete event handler. Without it, the mini-mode window is not really hidden when clicking on the close button.

The only issue that wasn't addressed by the patch is the following:

When the user clicks on the notification icon after closing the mini-mode window, the main window is shown, not the mini-mode one.

I'm not sure if this should be fixed or if it's an expected behaviour.
Comment 6 Gabriel Burt 2009-02-19 18:41:37 UTC 
Thanks Alex, your patch was pretty good, but it inspired me to do a bit more complete fix, including unaddressed issue you mentioned.  To do that, I changed the MiniModeWindow to sublcass from BaseClientWindow, and set the minimode window as the PrimaryWindow when it is enabled.  I also fixed up some bugs in the save/restore size/position logic so it should work better/more consistently.

Thanks for the patch/inspiration.
Comment 7 Alexander Kojevnikov 2009-02-19 22:33:46 UTC 
No worries mate
Comment 8 Alexander Kojevnikov 2009-07-19 19:51:48 UTC 
*** Bug 589018 has been marked as a duplicate of this bug. ***