After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 437791 - Animation is played at the wrong speed
Animation is played at the wrong speed
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
: 537619 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-05-11 23:43 UTC by Björn Lindqvist
Modified: 2010-07-10 04:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Translate 0ms delay to 100ms (1.13 KB, patch)
2008-08-24 00:57 UTC, Björn Lindqvist 		committed Details | Review

Description Björn Lindqvist 2007-05-11 23:43:40 UTC 
See the GIF at this url: http://www.vulomedia.com/images/59546playingwii.gif (he IS playing Wii). In Firefox and Epiphany the animation runs at about 12 fps. But if you view it in gThumb it will play extremely fast. This is because gThumb uses GdkPixbufAnimation which has a bug which is causing this. It reports that the delay time for each frame is 20 milliseconds which is obviously wrong.

Severity major because there are a huge amounts of GIF:s like that.
Comment 1 Matthias Clasen 2007-05-11 23:52:04 UTC 
well, gdk-pixbuf only uses 20ms if the gif has an even more obviously wrong value of 0ms ...
Comment 2 Björn Lindqvist 2007-05-12 00:10:05 UTC 
Seems like that is the case with this file.. Then I'd like one of the following to happen:

1. The fallback delay to be changed to match Firefox.
2. GdkPixbufAnimation extended in some way so it is possible for applications to detect GIF animations with 0 ms delays. Then I could myself set a more reasonable delay for "broken" GIF:s.
Comment 3 Matthias Clasen 2007-05-18 15:19:07 UTC 
Ok, I'll break down here and admit that I don't mind changing the fallback value from 20 to 100.
Comment 4 Danilo Piazzalunga 2008-05-29 14:33:19 UTC 
I can definitely confirm this bug. It happens with every animated GIF which specifies a 0 ms delay.

I agree with the above comment: the fallback value should be incresed to 100 ms, both to match Firefox (and possibly other systems) and to provide a more reasonable default.
Comment 5 Björn Lindqvist 2008-08-24 00:57:35 UTC 
Created attachment 117286 [details] [review]
Translate 0ms delay to 100ms

This works
Comment 6 Björn Lindqvist 2008-08-29 22:22:12 UTC 
Committed to r21242:

2008-08-29  Björn Lindqvist  <bjourne@gmail.com>

	Bug 437791 – Animation is played at the wrong speed

	* gdk-pixbuf/io-gif.c (gif_get_lzw): Better 100 ms timeout for
	broken GIFs with 0 frame timeout.
Comment 7 Michael Chudobiak 2009-03-17 14:40:21 UTC 
*** Bug 537619 has been marked as a duplicate of this bug. ***