After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 437670 - Improvements for rtsptransport.[ch]
Improvements for rtsptransport.[ch]
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-11 11:50 UTC by Peter Kjellerstedt
Modified: 2007-05-11 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Improvements to rtsptransport.[ch] (17.40 KB, patch)
2007-05-11 11:52 UTC, Peter Kjellerstedt
committed Details | Review

Description Peter Kjellerstedt 2007-05-11 11:50:21 UTC
Please describe the problem:
Here is my patch with improvements for rtsptransport.[ch]:

* Add validation to rtsp_transport_parse().
* Add rtsp_transport_as_text() to generate an RTSP header from an RTSPTransport.
* Change ssrc to guint (was a string) since that is what it is, even though it is sent as a hex string.
* Correctly identify PLAY|RECORD mode parameters (the syntax in the RFC is incorrect, which can be seen when looking at the examples in the RFC).

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Peter Kjellerstedt 2007-05-11 11:52:30 UTC
Created attachment 88006 [details] [review]
Improvements to rtsptransport.[ch]
Comment 2 Wim Taymans 2007-05-11 15:25:35 UTC
        Patch by: Peter Kjellerstedt  <pkj at axis com>

        * gst/rtsp/rtsptransport.c: (rtsp_transport_init), (parse_mode),
        (parse_range), (range_as_text), (rtsp_transport_mode_as_text),
        (rtsp_transport_profile_as_text), (rtsp_transport_ltrans_as_text),
        (rtsp_transport_parse), (rtsp_transport_as_text):
        * gst/rtsp/rtsptransport.h:
        Add validation to rtsp_transport_parse().
        Add rtsp_transport_as_text() to generate an RTSP header from an
        RTSPTransport.
        Change ssrc to guint (was a string) since that is what it is, even
        though it is sent as a hex string.
        Correctly identify PLAY|RECORD mode parameters (the syntax in the RFC is
        incorrect, which can be seen when looking at the examples in the RFC).
        Fixes #437670.